So far we have three +1 votes and one note from Flavio regarding the copyright year in the NOTICE file. Given that copyright fix https://github.com/apache/bookkeeper/pull/2621 is merged and scheduled for 4.13.1 I'd like to proceed with the release.
---------- Andrey Yegorov On Tue, Feb 23, 2021 at 10:23 PM Enrico Olivelli <eolive...@gmail.com> wrote: > Jia, > The KEYS file is at another location, please check the initial message from > this thread > > I imported Andrey's key correctly > > Enrico > > Il Mer 24 Feb 2021, 02:34 Jia Zhai <zhaiji...@gmail.com> ha scritto: > > > +1(binding) > > Environment: macOS 10.15.6, jdk 8. > > > > - verified packages checksum and signatures, they look good. > > > > - the source package build and test all run successfully. > > > > - in both binary package(server & all) and the target that build from src > > package, after change standalone.conf of allowloopback=true, > > 'bin/bookkeeper standalone' > > and 'bin/bookkeeper shell bookiesanity' runs well. > > > > > > some small issues need to be fix: > > "gpg --verify" command will meet error: "gpg: Can't check signature: No > > public key" > > And the KEYS file seems been removed from root dir: > > https://dist.apache.org/repos/dist/dev/bookkeeper/ > > > > > > Best Regards. > > > > > > Jia Zhai > > > > Beijing, China > > > > Mobile: +86 15810491983 > > > > > > > > > > On Wed, Feb 24, 2021 at 1:54 AM Henry Saputra <henry.sapu...@gmail.com> > > wrote: > > > > > +1 (binding) > > > LICENSE file looks good > > > NOTICE file looks good > > > Signature file looks good > > > Checksum file matched > > > No binary in the source artifact distribution > > > RAT, Checkstyle passed > > > Source compiled and tests passed (OSX, Java 1.8) > > > > > > On Thu, Feb 18, 2021 at 9:48 AM Andrey Yegorov < > andrey.yego...@gmail.com > > > > > > wrote: > > > > > > > Hi everyone, > > > > > > > > Please review and vote on the release candidate #0 for the version > > > 4.13.0, > > > > as follows: > > > > [ ] +1, Approve the release > > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > > > The complete staging area is available for your review, which > includes: > > > > * Release notes [1] https://github.com/apache/bookkeeper/pull/2607 > > > > > > > > > > > > > > https://github.com/apache/bookkeeper/blob/b70b9c41e997ac1beccff2b3db89c3579609dcdd/site/docs/4.13.0/overview/releaseNotes.md > > > > > > > > * The official Apache source and binary distributions to be deployed > to > > > > dist.apache.org [2] > > > > > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.13.0-rc0/ > > > > * All artifacts to be deployed to the Maven Central Repository [3] > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/staging/org/apache/bookkeeper/ > > > > * Source code tag "v4.13.0-rc0" [4] with git sha > > > > 787e2fac391c32b80aa9e9f44d26d1b69c07dbe0 > > > > https://github.com/apache/bookkeeper/tree/v4.13.0-rc0 > > > > > > > > BookKeeper's KEYS file contains PGP keys we used to sign this > release: > > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > > > > > Please download these packages and review this release candidate: > > > > > > > > - Review release notes > > > > - Download the source package (verify shasum, and asc) and follow the > > > > instructions to build and run the bookkeeper service. > > > > - Download the binary package (verify shasum, and asc) and follow the > > > > instructions to run the bookkeeper service. > > > > - Review maven repo, release tag, licenses, and any other things you > > > think > > > > it is important to a release. > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > majority > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > Thanks, > > > > Release Manager > > > > ---------- > > > > Andrey Yegorov > > > > > > > > > >
