I ran another build overnight and this time it finished successfully. It does
look like there are a few flaky tests.
As for whether the NOTICE file issue is a blocker, the ASF documentation is not
very clear about the year in the copyright:
https://infra.apache.org/licensing-howto.html
but from my past discussions with legal in this company and others, I get that
it is important, especially when an issue becomes known. I'd rather be cautious
and fix it before releasing, but I see a bunch of +1 votes already, and
everything else I checked so far looks good. There are flaky tests, but they
don't seem to be specific to this release.
-Flavio
> On 24 Feb 2021, at 10:01, Henry Saputra <henry.sapu...@gmail.com> wrote:
>
> Hmm I did not see those errors
>
> Oh, and I have sent PR for the NOTICE file here:
> https://github.com/apache/bookkeeper/pull/2621
>
> Wonder if they happen due to "flaky" tests
>
> - Henry
>
> On Tue, Feb 23, 2021 at 2:15 PM Flavio Junqueira <f...@apache.org> wrote:
>
>> A couple of things:
>>
>> 1- I haven't been able to get a clean build, I'll list the tests failures
>> I observed below.
>> 2- We need to update the year range in the NOTICE file to say 2021 instead
>> of 2020.
>>
>> -Flavio
>>
>>
>> [ERROR]
>> org.apache.bookkeeper.client.SlowBookieTest.testSlowBookieAndFastFailOn
>> Time elapsed: 3.384 s <<< FAILURE!
>> java.lang.AssertionError: There should be no missing fragments
>> expected:<0> but was:<1>
>> at org.junit.Assert.fail(Assert.java:88)
>> at org.junit.Assert.failNotEquals(Assert.java:834)
>> at org.junit.Assert.assertEquals(Assert.java:645)
>> at
>> org.apache.bookkeeper.client.SlowBookieTest.doBackpressureTest(SlowBookieTest.java:293)
>> at
>> org.apache.bookkeeper.client.SlowBookieTest.testSlowBookieAndFastFailOn(SlowBookieTest.java:197)
>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> at
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>> at
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> at java.lang.reflect.Method.invoke(Method.java:498)
>> at
>> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>> at
>> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>> at
>> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>> at
>> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>> at
>> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>> at
>> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>> at
>> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
>> at
>> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
>> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>> at java.lang.Thread.run(Thread.java:748)
>>
>>
>> [ERROR]
>> org.apache.bookkeeper.client.TestReadLastConfirmedLongPoll.testReadLACLongPollWhenSomeBookiesDown[0]
>> Time elapsed: 5.726 s <<< FAILURE!
>> java.lang.AssertionError
>> at org.junit.Assert.fail(Assert.java:86)
>> at org.junit.Assert.assertTrue(Assert.java:41)
>> at org.junit.Assert.assertTrue(Assert.java:52)
>> at
>> org.apache.bookkeeper.client.TestReadLastConfirmedLongPoll.testReadLACLongPollWhenSomeBookiesDown(TestReadLastConfirmedLongPoll.java:184)
>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> at
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>> at
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> at java.lang.reflect.Method.invoke(Method.java:498)
>> at
>> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>> at
>> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>> at
>> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>> at
>> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>> at
>> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>> at
>> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>> at
>> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
>> at
>> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
>> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>> at java.lang.Thread.run(Thread.java:748)
>>
>>
>> [ERROR]
>> org.apache.bookkeeper.bookie.CompactionByBytesTest.testCompactionFailureShouldNotResultInDuplicatedData
>> Time elapsed: 16.374 s <<< FAILURE!
>> java.lang.AssertionError: Entry log file ([0,1,2].log should have been
>> compacted in ledgerDirectory: /tmp/bookie6403976059727115417test
>> at org.junit.Assert.fail(Assert.java:88)
>> at org.junit.Assert.assertTrue(Assert.java:41)
>> at org.junit.Assert.assertFalse(Assert.java:64)
>> at
>> org.apache.bookkeeper.bookie.CompactionTest.testCompactionFailureShouldNotResultInDuplicatedData(CompactionTest.java:1360)
>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> at
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>> at
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> at java.lang.reflect.Method.invoke(Method.java:498)
>> at
>> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>> at
>> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>> at
>> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>> at
>> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>> at
>> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>> at
>> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>> at
>> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
>> at
>> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
>> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>> at java.lang.Thread.run(Thread.java:748)
>>
>>
>>
>>> On 23 Feb 2021, at 18:54, Henry Saputra <henry.sapu...@gmail.com> wrote:
>>>
>>> +1 (binding)
>>> LICENSE file looks good
>>> NOTICE file looks good
>>> Signature file looks good
>>> Checksum file matched
>>> No binary in the source artifact distribution
>>> RAT, Checkstyle passed
>>> Source compiled and tests passed (OSX, Java 1.8)
>>>
>>> On Thu, Feb 18, 2021 at 9:48 AM Andrey Yegorov <andrey.yego...@gmail.com
>>>
>>> wrote:
>>>
>>>> Hi everyone,
>>>>
>>>> Please review and vote on the release candidate #0 for the version
>> 4.13.0,
>>>> as follows:
>>>> [ ] +1, Approve the release
>>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>>
>>>> The complete staging area is available for your review, which includes:
>>>> * Release notes [1] https://github.com/apache/bookkeeper/pull/2607
>>>>
>>>>
>> https://github.com/apache/bookkeeper/blob/b70b9c41e997ac1beccff2b3db89c3579609dcdd/site/docs/4.13.0/overview/releaseNotes.md
>>>>
>>>> * The official Apache source and binary distributions to be deployed to
>>>> dist.apache.org [2]
>>>>
>> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.13.0-rc0/
>>>> * All artifacts to be deployed to the Maven Central Repository [3]
>>>>
>>>>
>> https://repository.apache.org/content/repositories/staging/org/apache/bookkeeper/
>>>> * Source code tag "v4.13.0-rc0" [4] with git sha
>>>> 787e2fac391c32b80aa9e9f44d26d1b69c07dbe0
>>>> https://github.com/apache/bookkeeper/tree/v4.13.0-rc0
>>>>
>>>> BookKeeper's KEYS file contains PGP keys we used to sign this release:
>>>> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>>>>
>>>> Please download these packages and review this release candidate:
>>>>
>>>> - Review release notes
>>>> - Download the source package (verify shasum, and asc) and follow the
>>>> instructions to build and run the bookkeeper service.
>>>> - Download the binary package (verify shasum, and asc) and follow the
>>>> instructions to run the bookkeeper service.
>>>> - Review maven repo, release tag, licenses, and any other things you
>> think
>>>> it is important to a release.
>>>>
>>>> The vote will be open for at least 72 hours. It is adopted by majority
>>>> approval, with at least 3 PMC affirmative votes.
>>>>
>>>> Thanks,
>>>> Release Manager
>>>> ----------
>>>> Andrey Yegorov
>>>>
>>
>>
