[
https://issues.apache.org/jira/browse/BOOKKEEPER-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995959#comment-15995959
]
ASF GitHub Bot commented on BOOKKEEPER-1008:
--------------------------------------------
Github user merlimat commented on the issue:
https://github.com/apache/bookkeeper/pull/116
I have been testing quite a while with the leak detector and across all the
leaked files I haven't seen any since netty 4 created socket.
What I mostly saw with the file leak detector has been a whole bunch of
file leaks in different tests. Eg:
* Tests that instantiate bookies and call `shutdown()` without calling
`start()` before are creating and initializing the ledger storage but not
closing it, leaking threads and several fds
* ZooKeeperClient sometimes doesn't shutdown the zk handle if the test
completes too quickly, leaking sockets.
* Several tests are passing bad config, so the bookie/client start gets
exception (on purpose) and then doesn't clean up some partial objects.
* ...
I don't think there is an easy fix for the issue. A bigger refactor would
be needed to address them.
Also, I've noticed that in `pom.xml` there was already:
```xml
<forkMode>always</forkMode>
```
This directive was intended to use a fresh JVM fork for each test, but it's
deprecated in maven and it doesn't seem to be working.
I'd propose to fix that and to use in the surefire configuration:
```xml
<reuseForks>true</reuseForks>
```
I'll create a separate Jira for this.
> Move to netty4
> --------------
>
> Key: BOOKKEEPER-1008
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1008
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.5.0
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
>
> As part of the Yahoo push back and in general we would like to move to netty
> 4, preferably netty 4.1.x for the client and server communication.
> This lays the ground work for zero copy, or very nearly zero copy handling on
> the server side.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
