[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15757189#comment-15757189
 ] 

Francesco Caliumi commented on BOOKKEEPER-974:
----------------------------------------------

Hi [~eolivelli], thanks for trying it out.
Yes, bookies need that ZK metadata is properly formatted in order to start and 
as a workaround you can pass "--env FORMAT_METADATA=yes" when running the first 
BK container. This is obviously not the ideal solution, though. A better one 
should be to check ZK if metadata is present and format if it isn't.

About your ideas:
- data/index/journal in separate volumes: absolutely right
- configuration file: there are different ways of achieving this, but they are 
not straight forward. About configuration, I could create a volume (e.g. /conf) 
that, if it contains something, it will replace the bookkeeper/conf dir. Then 
what we should do with env variables (like ZK_SERVERS)? In my opinion it would 
be better to not substitute them in conf file because if the user doesn't 
specify anything they will be replaced by default ones. However, if the user 
specify a variable, it won't be replaced if /conf is present, that bring to a 
counterintuitive behavior (IMHO). What's your opinion?
- single configuration options: yes, I will add a env variable "BOOKIE_OPTS" 
that will be appended to bookie command at run (i.e. bin/bookkeeper bookie 
${BOOKIE_OPTS})
- bookkeeper shell: sure. I was thinking to pass any parameters given to docker 
run directly at bin/bookkeeper, like:
{code}
docker run --rm --network host -e ZK_SERVERS=$(hostname):2181 -it 
caiok/bookkeeper:4.4.0 shell metaformat
{code}


> make pushing a docker image as part of the release procedure
> ------------------------------------------------------------
>
>                 Key: BOOKKEEPER-974
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-974
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Jia Zhai
>
> make pushing a docker image as part of the release procedure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to