[
https://issues.apache.org/jira/browse/AVRO-3453?focusedWorklogId=744834&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744834
]
ASF GitHub Bot logged work on AVRO-3453:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/22 04:22
Start Date: 21/Mar/22 04:22
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on a change in pull request #1605:
URL: https://github.com/apache/avro/pull/1605#discussion_r830750808
##########
File path: lang/csharp/src/apache/main/CodeGen/CodeGenUtil.cs
##########
@@ -132,5 +144,21 @@ public string UnMangle(string name)
builder.Append(name[i]);
return builder.ToString();
}
+
+ private CodeAttributeDeclaration GetGeneratedCodeAttribute()
Review comment:
Get the InformationalVersion attribute for the full version. IMO the
FileVersion or AssembleVersion are pretty much useless, since it does not
support SemVer. Since this project supports pre-release label, we should use
it. I would even change it in the header comments, since that version does not
reflect the real version (if pre-released). I understand that pre-release
version is not pushed to nuget, however it is released in github,
IMO using the proper and full version makes your life easier when you
implement the unit tests. E.g. whatever avrogen --version returns, should be
the version tag written in the cs file. Otherwise it is confusing for the end
user if avrogen --version returns something different than the version tag
written in the generated cs file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 744834)
Time Spent: 3h 40m (was: 3.5h)
> C# Avrogen Add Generated Code Attribute
> ---------------------------------------
>
> Key: AVRO-3453
> URL: https://issues.apache.org/jira/browse/AVRO-3453
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.1
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Development environments that use Code Analysis or something similar attempt
> to exclude auto generated code. By adding this attribute to generated
> classes, code analysis will skip over evaluating the code.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
