[
https://issues.apache.org/jira/browse/AVRO-3453?focusedWorklogId=744749&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744749
]
ASF GitHub Bot logged work on AVRO-3453:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/22 18:25
Start Date: 20/Mar/22 18:25
Worklog Time Spent: 10m
Work Description: KyleSchoonover commented on pull request #1605:
URL: https://github.com/apache/avro/pull/1605#issuecomment-1073306325
So first, it's not breaking. It has the potential to break if we go to
something else to generate the classes (and they remove it from the framework).
The System.CodeDom is already a dependency of the Avro library, which is
referenced in Avro, and potentially the generated files. This sort of
implicit dependency chain is normal in the case of generated code.
Additionally, System.CodeDom is part of the framework. We just happen to make
reference to a specific version. It's been there for a very long time, so if
Avro removes the reference in anyway the generated code will not break.
Second, we should look at what this accomplishes:
1. Makes it so the class can not be inherited. Another option is to seal
the class.
2. Makes it so things like CodeAnalysis and StyleCop ignore the file.
Another option is using
`[System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]` There is nothing
available to suppress a whole file for StyleCop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 744749)
Time Spent: 2h (was: 1h 50m)
> C# Avrogen Add Generated Code Attribute
> ---------------------------------------
>
> Key: AVRO-3453
> URL: https://issues.apache.org/jira/browse/AVRO-3453
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.1
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Development environments that use Code Analysis or something similar attempt
> to exclude auto generated code. By adding this attribute to generated
> classes, code analysis will skip over evaluating the code.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
