[
https://issues.apache.org/jira/browse/AVRO-3453?focusedWorklogId=744841&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744841
]
ASF GitHub Bot logged work on AVRO-3453:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/22 04:48
Start Date: 21/Mar/22 04:48
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on a change in pull request #1605:
URL: https://github.com/apache/avro/pull/1605#discussion_r830756918
##########
File path: lang/csharp/src/apache/main/CodeGen/CodeGenUtil.cs
##########
@@ -132,5 +144,21 @@ public string UnMangle(string name)
builder.Append(name[i]);
return builder.ToString();
}
+
+ private CodeAttributeDeclaration GetGeneratedCodeAttribute()
Review comment:
To make your life more complicated:
```
// VERSION.txt = 1.12.1-SNAPSHOT
string version =
Assembly.GetExecutingAssembly().GetName().Version.ToString(); // => 1.12.0.0
INCORRECT
string fullVersion =
Assembly.GetExecutingAssembly().GetCustomAttribute<AssemblyInformationalVersionAttribute>().InformationalVersion.ToString();
// => 1.12.1-SNAPSHOT CORRECT
```
FileVersion is set in common.props, which is defined as
`<FileVersion>$(MajorVersion).$(MinorVersion).$(BuildNumber).0</FileVersion>`
which IMO is incorrect and it should be
`<FileVersion>$(MajorVersion).$(MinorVersion).$(PatchNumber).0</FileVersion>`.
Probably it is a good idea to fix in another ticket, because the e.g.
1.11.1, the version written into the cs files will be 1.11.0 :(. It definetely
makes sense not to tryst thany other version, except he InformationalVersion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 744841)
Time Spent: 4h (was: 3h 50m)
> C# Avrogen Add Generated Code Attribute
> ---------------------------------------
>
> Key: AVRO-3453
> URL: https://issues.apache.org/jira/browse/AVRO-3453
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.1
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Development environments that use Code Analysis or something similar attempt
> to exclude auto generated code. By adding this attribute to generated
> classes, code analysis will skip over evaluating the code.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
