El jue, 24 oct 2024 a las 0:14, Sutou Kouhei (<k...@clear-code.com>) escribió: > > Hi, > > There are no -1 vote yet here but a conda-forge package > maintainer reports a cross-compiling related problem in > 18.0.0 RC0: > > https://github.com/apache/arrow/issues/44448#issuecomment-2431000046 > > > When a major distribution channel ends up being broken, > > that should be the definition of a release blocker, even > > though we'll manage to backport the patch (again, thanks > > for that). It's not about the effort to backport, it's > > about what role conda-forge has. With several million > > downloads, the arrow feedstock should IMO be important > > enough to be a release consideration (that's originally > > why the conda-forge CI was integrated into this repo...) > > The issue includes 2 problems: (1) <nmmintrin.h> related and > (2) grpc_cpp_plugin related. > > (1) is a CMake usage problem by the conda-forge package. So > this is not a 18.0.0 RC0 blocker. > > (2) is a cross-compiling problem. Apache Arrow C++ doesn't > have enough cross-compiling support so far because our CI > doesn't have cross-compiling jobs except > dev/tasks/conda-recipes/ related jobs and Emscripten related > jobs. > > dev/tasks/conda-recipes/ related jobs are based on > https://github.com/conda-forge/arrow-cpp-feedstock . So we > need to keep synchronizing them to detect conda-forge > package related problems. > > The last sync is done by > https://github.com/apache/arrow/pull/37624 (2023-09-28). So > dev/tasks/conda-recipes/ isn't the latest. > > FYI: https://github.com/apache/arrow/pull/44507 is the patch > for (2). > > > Should we release RC0 as 18.0.0? Or should we cut RC1 with > some patches including the patch for (2)? Could you share > your thought? > > I think that we can release RC0 as 18.0.0 because: > > * This is not a regression. The cross-compiling problem > exists in the past releases. > * Unfortunately, our release cost is still high... Cutting a > new RC isn't light operation... >
I shared my opinion on the GH issue but to me it comes more to the release cost and the alternative solution. I would personally consider the issue a release blocker if we wouldn't have a solution and conda-forge was broken with the new release. Having a patch that can be easily backported and with the current costs to create a new RC I would prefer to ship RC0 and just backport the patch to conda. Thanks, Raúl > > Thanks, > -- > kou > > In <cad1rbrrnu1d0xs5-xmt+ed4jujpykfp5r53tameftbmah5z...@mail.gmail.com> > "[VOTE] Release Apache Arrow 18.0.0 - RC0" on Fri, 18 Oct 2024 12:25:08 > +0200, > Raúl Cumplido <rau...@apache.org> wrote: > > > Hi, > > > > I would like to propose the following release candidate (RC0) of Apache > > Arrow version 18.0.0. This is a release consisting of 327 > > resolved GitHub issues[1]. > > > > This release candidate is based on commit: > > 9105a4109a80a1c01eabb24ee4b9f7c94ee942cb [2] > > > > The source release rc0 is hosted at [3]. > > The binary artifacts are hosted at [4][5][6][7][8][9][10][11]. > > The changelog is located at [12]. > > > > Please download, verify checksums and signatures, run the unit tests, > > and vote on the release. See [13] for how to validate a release candidate. > > > > See also a verification result on GitHub pull request [14]. > > > > The vote will be open for at least 72 hours. > > > > [ ] +1 Release this as Apache Arrow 18.0.0 > > [ ] +0 > > [ ] -1 Do not release this as Apache Arrow 18.0.0 because... > > > > [1]: > > https://github.com/apache/arrow/issues?q=is%3Aissue+milestone%3A18.0.0+is%3Aclosed > > [2]: > > https://github.com/apache/arrow/tree/9105a4109a80a1c01eabb24ee4b9f7c94ee942cb > > [3]: https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-18.0.0-rc0 > > [4]: https://apache.jfrog.io/artifactory/arrow/almalinux-rc/ > > [5]: https://apache.jfrog.io/artifactory/arrow/amazon-linux-rc/ > > [6]: https://apache.jfrog.io/artifactory/arrow/centos-rc/ > > [7]: https://apache.jfrog.io/artifactory/arrow/debian-rc/ > > [8]: https://apache.jfrog.io/artifactory/arrow/java-rc/18.0.0-rc0 > > [9]: https://apache.jfrog.io/artifactory/arrow/nuget-rc/18.0.0-rc0 > > [10]: https://apache.jfrog.io/artifactory/arrow/python-rc/18.0.0-rc0 > > [11]: https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/ > > [12]: > > https://github.com/apache/arrow/blob/9105a4109a80a1c01eabb24ee4b9f7c94ee942cb/CHANGELOG.md > > [13]: https://arrow.apache.org/docs/developers/release_verification.html > > [14]: https://github.com/apache/arrow/pull/44440
