+1 (binding)

I'm having some issue with wheels, but I believe this is just a verification 
script issue [1]:

+ python -c 'import pyarrow._s3fs'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: 
/tmp/arrow-test/miniforge/envs/conda-wheel-3.9-manylinux_2_28_x86_64/lib/python3.9/site-packages/pyarrow/_s3fs.cpython-39-x86_64-linux-gnu.so:
 undefined symbol: _ZN5arrow2fs17EnsureS3FinalizedEv

However, libarrow.so does define the symbol and _s3fs.so does link to 
libarrow.so.  And if I activate the Conda environment by hand and run the 
import, there is no issue. 

Poking around more, it's because test_source_distribution sets LD_LIBRARY_PATH 
and this apparently leaks into the environment used to test the wheels.

[1]: https://gist.github.com/lidavidm/8460c64efc0d19338c53b11c15e82f13

On Wed, Oct 23, 2024, at 02:31, Rok Mihevc wrote:
> +1
>
> On Ubuntu 24.04.1 LTS I executed:
>
> TEST_DEFAULT=0 USE_CONDA=1 TEST_SOURCE=1 TEST_PYTHON=0
> TEST_INTEGRATION_JAVA=0 ./verify-release-candidate.sh 18.0.0 0
>
> (Java integration test failed to find archery and python couldn't compile
> for HDFS (probably due to lack of drivers on my system) so non-issues I
> think)
>
> On Tue, Oct 22, 2024 at 9:40 AM Sutou Kouhei <k...@clear-code.com> wrote:
>
>> +1 (binding)
>>
>> I ran the followings on Debian GNU/Linux sid:
>>
>>   * TEST_DEFAULT=0 \
>>       TEST_SOURCE=1 \
>>       LANG=C \
>>       TZ=UTC \
>>       ARROW_CUDA=NO \
>>       ARROW_CMAKE_OPTIONS="-DBoost_NO_BOOST_CMAKE=ON
>> -Dxsimd_SOURCE=BUNDLED" \
>>       dev/release/verify-release-candidate.sh 18.0.0 0
>>
>>   * TEST_DEFAULT=0 \
>>       TEST_APT=1 \
>>       LANG=C \
>>       dev/release/verify-release-candidate.sh 18.0.0 0
>>
>>   * TEST_DEFAULT=0 \
>>       TEST_BINARY=1 \
>>       LANG=C \
>>       dev/release/verify-release-candidate.sh 18.0.0 0
>>
>>   * TEST_DEFAULT=0 \
>>       TEST_JARS=1 \
>>       LANG=C \
>>       dev/release/verify-release-candidate.sh 18.0.0 0
>>
>>   * TEST_DEFAULT=0 \
>>       TEST_PYTHON_VERSIONS=3.11 \
>>       TEST_WHEELS=1 \
>>       LANG=C \
>>       dev/release/verify-release-candidate.sh 18.0.0 0
>>
>>   * TEST_DEFAULT=0 \
>>       TEST_YUM=1 \
>>       LANG=C \
>>       dev/release/verify-release-candidate.sh 18.0.0 0
>>
>> with:
>>
>>   * .NET SDK (8.0.303)
>>   * Python 3.11.9
>>   * gcc (Debian 13.3.0-2) 13.3.0
>>   * openjdk version "17.0.12-ea" 2024-07-16
>>   * ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-linux-gnu]
>>
>> Notes:
>>
>> * I disabled arm64v8/ubuntu:focal and arm64v8/ubuntu:jammy
>>   APT packages test because libc related SEGV is caused on
>>   my environment.
>>
>> * There are tzdata related Python wheels failures:
>>   https://github.com/apache/arrow/issues/44455
>>
>>   But I think that it's not a blocker. Because (I think
>>   that) the problem exists in 17.0.0 too.
>>
>>
>>
>> Thanks,
>> --
>> kou
>>
>>
>> In <cad1rbrrnu1d0xs5-xmt+ed4jujpykfp5r53tameftbmah5z...@mail.gmail.com>
>>   "[VOTE] Release Apache Arrow 18.0.0 - RC0" on Fri, 18 Oct 2024 12:25:08
>> +0200,
>>   Raúl Cumplido <rau...@apache.org> wrote:
>>
>> > Hi,
>> >
>> > I would like to propose the following release candidate (RC0) of Apache
>> > Arrow version 18.0.0. This is a release consisting of 327
>> > resolved GitHub issues[1].
>> >
>> > This release candidate is based on commit:
>> > 9105a4109a80a1c01eabb24ee4b9f7c94ee942cb [2]
>> >
>> > The source release rc0 is hosted at [3].
>> > The binary artifacts are hosted at [4][5][6][7][8][9][10][11].
>> > The changelog is located at [12].
>> >
>> > Please download, verify checksums and signatures, run the unit tests,
>> > and vote on the release. See [13] for how to validate a release
>> candidate.
>> >
>> > See also a verification result on GitHub pull request [14].
>> >
>> > The vote will be open for at least 72 hours.
>> >
>> > [ ] +1 Release this as Apache Arrow 18.0.0
>> > [ ] +0
>> > [ ] -1 Do not release this as Apache Arrow 18.0.0 because...
>> >
>> > [1]:
>> https://github.com/apache/arrow/issues?q=is%3Aissue+milestone%3A18.0.0+is%3Aclosed
>> > [2]:
>> https://github.com/apache/arrow/tree/9105a4109a80a1c01eabb24ee4b9f7c94ee942cb
>> > [3]:
>> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-18.0.0-rc0
>> > [4]: https://apache.jfrog.io/artifactory/arrow/almalinux-rc/
>> > [5]: https://apache.jfrog.io/artifactory/arrow/amazon-linux-rc/
>> > [6]: https://apache.jfrog.io/artifactory/arrow/centos-rc/
>> > [7]: https://apache.jfrog.io/artifactory/arrow/debian-rc/
>> > [8]: https://apache.jfrog.io/artifactory/arrow/java-rc/18.0.0-rc0
>> > [9]: https://apache.jfrog.io/artifactory/arrow/nuget-rc/18.0.0-rc0
>> > [10]: https://apache.jfrog.io/artifactory/arrow/python-rc/18.0.0-rc0
>> > [11]: https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/
>> > [12]:
>> https://github.com/apache/arrow/blob/9105a4109a80a1c01eabb24ee4b9f7c94ee942cb/CHANGELOG.md
>> > [13]: https://arrow.apache.org/docs/developers/release_verification.html
>> > [14]: https://github.com/apache/arrow/pull/44440
>>

Reply via email to