On Thu, 21 Nov 2019 08:40:10 -0500 Francois Saint-Jacques <fsaintjacq...@gmail.com> wrote: > This notation is already used in some parts of the codebase [1]. I > think it was introduced when absorbing gandiva and then in a draft of > the logical operations in the compute module. I have no strong opinion > for/against. I find it convenient to reduce typing, but the style > guide argue against this. > > What about other aliases (Vector & Iterator)? If we revert this > change, we should do it uniformly, e.g. in gandiva and compute.
Vector and Iterator sound ok to me (though Iterator could yield some confusion with STL iterators, and Iterator<T> isn't really longer to type than TIterator). Regards Antoine.
