On Wed, 20 Nov 2019 20:50:12 -0800 Micah Kornfield <emkornfi...@gmail.com> wrote: > A recent PR for datasets [1] seems to have introduced the convention of > aliasing "std::shared_ptr<Type>" with "TypePtr" for some type. I think in > the past we had decided not to use a convention like this but I can't find > the thread. IMO, I think this generally makes the code less understandable > but this is a matter of taste.
I agree this introduces ambiguity for casual readers of the code. The question is whether the savings in typing are worth it. Personally, I've become used to writing "shared_ptr" a lot :-) Regards Antoine.
