Neville, I think we should be able to fix the two bugs you mentioned within this week. I'll take a look. It would be great if you can provide more details in the JIRAs (e.g., test case to reproduce). Array currently doesn't expose a bitmask API, and I don't think we need specialized implementations for struct & list.
Chao On Mon, Mar 18, 2019 at 8:24 PM Neville Dipale <nevilled...@gmail.com> wrote: > Hi Wes, > > In Rust, we have 2 bugs (https://issues.apache.org/jira/browse/ARROW-4914, > https://issues.apache.org/jira/browse/ARROW-4886) both related to array > slicing. > > In summary: > > * ARROW-4914, the bitmask of the original array is used to determine the > validity of the sliced array, but offsets aren't read correctly. An array > with 10111 sliced with (offset=2, len=3) will return bitmask of 101 instead > of 111 > * ARROW-4886, we implemented slice on the Array interface, but don't have > specialised implementations for struct and list, so we leak the > implementation. > > I think if we can't get to both by the time we release an RC, the best > solution would be to revert > https://issues.apache.org/jira/browse/ARROW-3954 > . > > Any thoughts from Rust commiters? > > Neville > > On Tue, 19 Mar 2019, 03:51 Wes McKinney, <wesmck...@gmail.com> wrote: > > > hi folks, > > > > I think we're basically at the 0.13 end game here. There's some more > > patches can get in, but do we all think we can cut an RC by the end of > > the week? What are the blocking issues? > > > > Thanks > > Wes > > > > On Sat, Mar 16, 2019 at 9:57 PM Kouhei Sutou <k...@clear-code.com> wrote: > > > > > > Hi, > > > > > > > Submitted the packaging builds: > > > > > > > https://github.com/kszucs/crossbow/branches/all?utf8=%E2%9C%93&query=build-452 > > > > > > I've fixed .deb/.rpm packages: > https://github.com/apache/arrow/pull/3934 > > > It has been merged. > > > So .deb/.rpm packages are ready for release. > > > > > > Thanks, > > > -- > > > kou > > > > > > In <cahm19a5somzxgcphc6ee-mr2usvvhwb252udgjrvocq-cb2...@mail.gmail.com > > > > > "Re: Timeline for 0.13 Arrow release" on Thu, 14 Mar 2019 16:24:43 > > +0100, > > > Krisztián Szűcs <szucs.kriszt...@gmail.com> wrote: > > > > > > > Submitted the packaging builds: > > > > > > > https://github.com/kszucs/crossbow/branches/all?utf8=%E2%9C%93&query=build-452 > > > > > > > > On Thu, Mar 14, 2019 at 4:19 PM Wes McKinney <wesmck...@gmail.com> > > wrote: > > > > > > > >> The CMake refactor is merged! Kudos to Uwe for 3+ weeks of hard > labor > > on > > > >> this. > > > >> > > > >> We should run all the packaging tasks and get a full accounting of > > > >> what is broken so we aren't surprised during the release process > > > >> > > > >> On Wed, Mar 13, 2019 at 9:39 AM Krisztián Szűcs > > > >> <szucs.kriszt...@gmail.com> wrote: > > > >> > > > > >> > The proof of the pudding is in the eating. You convinced me. > > > >> > > > > >> > On Wed, Mar 13, 2019 at 3:31 PM Wes McKinney <wesmck...@gmail.com > > > > > >> wrote: > > > >> > > > > >> > > Krisztian -- are you all right with proceeding with merging the > > CMake > > > >> > > refactor? I'm pretty committed to helping fix the problems that > > come > > > >> > > up. Since most consumers of the project don't test until > _after_ a > > > >> > > release, we won't find out about some problems until we merge it > > and > > > >> > > release it. Thus, IMHO it doesn't make sense to wait another > 8-10 > > > >> > > weeks since we'd be delaying feedback for that long. There are > > also a > > > >> > > number of follow-on issues blocking on the refactor > > > >> > > > > > >> > > On Tue, Mar 12, 2019 at 11:39 AM Andy Grove < > > andygrov...@gmail.com> > > > >> wrote: > > > >> > > > > > > >> > > > I've cleaned up my issues for Rust, moving most of them to > > 0.14.0. > > > >> > > > > > > >> > > > I have two PRs in progress that I would appreciate reviews on: > > > >> > > > > > > >> > > > https://github.com/apache/arrow/pull/3671 - [Rust] Table API > > (a.k.a > > > >> > > > DataFrame) > > > >> > > > > > > >> > > > https://github.com/apache/arrow/pull/3851 - [Rust] Parquet > data > > > >> source > > > >> > > in > > > >> > > > DataFusion > > > >> > > > > > > >> > > > Once these are merged I have some small follow up PRs for > 0.13.0 > > > >> that I > > > >> > > can > > > >> > > > get done this week. > > > >> > > > > > > >> > > > Thanks, > > > >> > > > > > > >> > > > Andy. > > > >> > > > > > > >> > > > > > > >> > > > On Tue, Mar 12, 2019 at 8:21 AM Wes McKinney < > > wesmck...@gmail.com> > > > >> > > wrote: > > > >> > > > > > > >> > > > > hi folks, > > > >> > > > > > > > >> > > > > I think we are on track to be able to release toward the end > > of > > > >> this > > > >> > > > > month. My proposed timeline: > > > >> > > > > > > > >> > > > > * This week (March 11-15): feature/improvement push mostly > > > >> > > > > * Next week (March 18-22): shift to bug fixes, > stabilization, > > empty > > > >> > > > > backlog of feature/improvement JIRAs > > > >> > > > > * Week of March 25: propose release candidate > > > >> > > > > > > > >> > > > > Does this seem reasonable? This puts us at about 9-10 weeks > > from > > > >> 0.12. > > > >> > > > > > > > >> > > > > We need an RM for 0.13, any PMCs want to volunteer? > > > >> > > > > > > > >> > > > > Take a look at our release page: > > > >> > > > > > > > >> > > > > > > > >> > > > > > >> > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=103091219 > > > >> > > > > > > > >> > > > > Out of the open or in-progress issues, we have: > > > >> > > > > > > > >> > > > > * C#: 3 issues > > > >> > > > > * C++ (all components): 51 issues > > > >> > > > > * Java: 3 issues > > > >> > > > > * Python: 38 issues > > > >> > > > > * Rust (all components): 33 issues > > > >> > > > > > > > >> > > > > Please help curating the backlogs for each component. > There's > > a > > > >> > > > > smattering of issues in other categories. There are also 10 > > open > > > >> > > > > issues with No Component (and 20 resolved issues), those > need > > their > > > >> > > > > metadata fixed. > > > >> > > > > > > > >> > > > > Thanks, > > > >> > > > > Wes > > > >> > > > > > > > >> > > > > On Wed, Feb 27, 2019 at 1:49 PM Wes McKinney < > > wesmck...@gmail.com> > > > >> > > wrote: > > > >> > > > > > > > > >> > > > > > The timeline for the 0.13 release is drawing closer. I > > would say > > > >> we > > > >> > > > > > should consider a release candidate either the week of > > March 18 > > > >> or > > > >> > > > > > March 25, which gives us ~3 weeks to close out backlog > > items. > > > >> > > > > > > > > >> > > > > > There are around 220 issues open or in-progress in > > > >> > > > > > > > > >> > > > > > > > > >> > > > > https://cwiki.apache.org/confluence/display/ARROW/Arrow+0.13.0+Release > > > >> > > > > > > > > >> > > > > > Please have a look. If issues are not assigned to someone > > as the > > > >> next > > > >> > > > > > couple of weeks pass by I'll begin moving at least C++ and > > Python > > > >> > > > > > issues to 0.14 that don't seem like they're going to get > > done for > > > >> > > > > > 0.13. If development stakeholders for C#, Java, Rust, > Ruby, > > and > > > >> other > > > >> > > > > > components can review and curate the issues that would be > > > >> helpful. > > > >> > > > > > > > > >> > > > > > You can help keep the JIRA issues tidy by making sure to > > add Fix > > > >> > > > > > Version to issues and to make sure to add a Component so > > that > > > >> issues > > > >> > > > > > are properly categorized in the release notes. > > > >> > > > > > > > > >> > > > > > Thanks > > > >> > > > > > Wes > > > >> > > > > > > > > >> > > > > > On Sat, Feb 9, 2019 at 10:39 AM Wes McKinney < > > > >> wesmck...@gmail.com> > > > >> > > > > wrote: > > > >> > > > > > > > > > >> > > > > > > See > > > >> > > > > > > > >> > > > > > >> > > > https://cwiki.apache.org/confluence/display/ARROW/Release+Management+Guide > > > >> > > > > > > > > > >> > > > > > > The source release step is one of the places where > > problems > > > >> occur. > > > >> > > > > > > > > > >> > > > > > > On Sat, Feb 9, 2019, 10:33 AM <ane...@quiltdata.io > wrote: > > > >> > > > > > >> > > > >> > > > > > >> > > > >> > > > > > >> > On Feb 8, 2019, at 9:19 AM, Uwe L. Korn < > > m...@uwekorn.com> > > > >> > > wrote: > > > >> > > > > > >> > > > > >> > > > > > >> > We could dockerize some of the release steps to > ensure > > that > > > >> they > > > >> > > > > run in the same environment. > > > >> > > > > > >> > > > >> > > > > > >> I may be able to help with said Dockerization. If not > > for this > > > >> > > > > release, then for the next. Are there docs on which systems > we > > > >> wish to > > > >> > > > > target and/or any build steps beyond the current dev > > container ( > > > >> > > > > https://github.com/apache/arrow/tree/master/dev/container)? > > > >> > > > > > > > >> > > > > > >> > > >
