Thanks Brent! I've tried to polish the PR as best as I could (probably over-engineered by now :D) - I added relevant instructions for release managers. I'd be happy if final (re-)reviews could be made by tomorrow so I could start the voting thread.
Shahar On Tue, Jun 3, 2025 at 9:30 PM Brent Bovenzi <br...@astronomer.io.invalid> wrote: > Thanks for starting this Shahar! It's been great to see how excited the > community is about i18n. I love how many PRs from first time contributors > have come in. But yes, we should agree on standards before 3.1.0 is > released. > > I agree with everything so far. A few notes > - We will continue to add eslint rules to catch missing keys and or using > plaintext. > - Any new languages missing keys before a minor release should be excluded > - Eventually I would like to migrate the translations to a backend so > they're not hard coded into the UI or even airflow-core > - Code standards also need to be formalized before 3.1.0 is released (What > goes in common, what goes into a separate file, how do we group > translations inside a json file, etc) > > - Brent > > On Mon, Jun 2, 2025 at 1:54 AM Amogh Desai <amoghdesai....@gmail.com> > wrote: > > > Thanks for starting the thread Shahar! > > > > Well put up and far better than email discussions! > > > > Thanks & Regards, > > Amogh Desai > > > > > > On Sun, Jun 1, 2025 at 7:59 PM Jens Scheffler <j_scheff...@gmx.de.invalid > > > > wrote: > > > > > Hi all, > > > > > > thanks @shahar for posting the discussion and the document. First hand > > > also added a few comments but in general 99% agreeing to the > definitions > > > written there. > > > > > > After the text discussion is settled in a couple of days I'd propose to > > > make it a README in the translations folder > > > (airflow-core/src/airflow/ui/src/i18n/README.md) and referencing to it > > > in contributing-docs/15_node_environment_setup.rst > > > > > > I would not think this policy definition requires an AIP. We should > VOTE > > > about it I assume. And I see a +1 mostly from whyt I see here from my > > side. > > > > > > Jens > > > > > > On 01.06.25 15:03, Buğra Öztürk wrote: > > > > It is a good idea to bring procedures to maintain and keep the > > > consistency > > > > across all translations. > > > > I am not 100% sure if it needs an AIP but we should have this well > > > > documented in the repository documentation as well, after the Wiki. > > > > Guidelines for policies and procedures after all of them agreed for > > sure. > > > > Thanks! > > > > > > > > On Sun, Jun 1, 2025 at 11:42 AM Jarek Potiuk <ja...@potiuk.com> > wrote: > > > > > > > >> Yep. Absolutely introducing translation mechanisms and even a way to > > > verify > > > >> if translations are complete ( is a good starting point - but yes, > > just > > > a > > > >> starting point. > > > >> > > > >> Describing and agreeing the process of maintaining it is > > > >> absolutely necessary, so good you started it - not sure if it needs > an > > > AIP > > > >> (but definitely should be described, voted on and agreed for us to > > > follow - > > > >> to know what are the expectations and how we should all proceed - > like > > > what > > > >> happens when we add new terms -> how we make sure that all of them > are > > > >> translated etc. > > > >> > > > >> BTW. I have not added pre-commit, just a script that anyone can run > > with > > > >> `uv run` - pre-commit would prevent adding new translations before > all > > > of > > > >> the languages are complete so we have to figure out better ways of > > > >> automation after we figure out how we want to keep those > translations > > > >> maintained. > > > >> > > > >> J. > > > >> > > > >> > > > >> On Sun, Jun 1, 2025 at 10:16 AM Aritra Basu < > aritrabasu1...@gmail.com > > > > > > >> wrote: > > > >> > > > >>> Thanks for this, left a comment. Overall in agreement with it! > > > >>> -- > > > >>> Regards, > > > >>> Aritra Basu > > > >>> > > > >>> On Sun, 1 Jun 2025, 1:39 pm Wei Lee, <weilee...@gmail.com> wrote: > > > >>> > > > >>>> Thanks Shahar! Just left a few comments. > > > >>>> If we’re to make it part of an AIP, a standalone one would > probably > > be > > > >>>> better IMO. > > > >>>> > > > >>>> Best, > > > >>>> Wei > > > >>>> > > > >>>>> On Jun 1, 2025, at 3:09 PM, Shahar Epstein <sha...@apache.org> > > > >> wrote: > > > >>>>> Hello community! > > > >>>>> > > > >>>>> It's great to see that people from all over the world make > Airflow > > > >>>>> multilingual, thus accessible for even more people. > > > >>>>> However, as Jarek mentioned in Slack [1], and as Jens prepares a > PR > > > >>> that > > > >>>>> adds plenty of new terms [2] - > > > >>>>> I think that we need to make a short pause and discuss a > > > >>>>> maintainability policy. > > > >>>>> Jarek has already created a pre-commit [3] for automatically > > checking > > > >>>> that > > > >>>>> translations are completed, which is great - > > > >>>>> but except for automation, I think that we need to agree as a > > > >> community > > > >>>> on > > > >>>>> more broader terms, such as: responsibilities of language > > CODEOWNERS, > > > >>>>> translation workflows, and quality standards. Specifically, > within > > > >> the > > > >>>>> quality standards - we could list the "special terms" that > > > >> should(n't) > > > >>> be > > > >>>>> translated/transliterated [4]. > > > >>>>> When writing this mail I thought that I could keep it short to > > > >> include > > > >>> it > > > >>>>> here - but then it got too long :) > > > >>>>> Here's a link to a Google Docs I drafted - feel free to comment > and > > > >>>> suggest > > > >>>>> changes: > > > >>>>> > > > >> > > > > > > https://docs.google.com/document/d/1Db2i12A0ZMfRAdEvoz4RQ0dLf0OBAcEpSIU-Cw6W3u4/edit?usp=sharing > > > >>>>> I'd like to ask to put it to a vote either as an independent AIP, > > or > > > >> as > > > >>>> an > > > >>>>> extension of AIP-38 - so the policy will be clear and outlined > for > > > >>> future > > > >>>>> generations. > > > >>>>> If there's a consensus for my request, I'll migrate the contents > to > > > >> the > > > >>>>> Wiki. > > > >>>>> > > > >>>>> > > > >>>>> Sincerely, > > > >>>>> Shahar Epstein > > > >>>>> > > > >>>>> > > > >>>>> *References* > > > >>>>> [1] > > > >> > > https://apache-airflow.slack.com/archives/C0809U4S1Q9/p1748730841507939 > > > >>>>> [2] https://github.com/apache/airflow/pull/51243 > > > >>>>> [3] https://github.com/apache/airflow/pull/51269 > > > >>>>> [4] > > https://lists.apache.org/thread/bvsvoo4nln22wqkncxogpgtlpcd1fffj > > > >>>> > > > >>>> > > --------------------------------------------------------------------- > > > >>>> To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org > > > >>>> For additional commands, e-mail: dev-h...@airflow.apache.org > > > >>>> > > > >>>> > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org > > > For additional commands, e-mail: dev-h...@airflow.apache.org > > > > > > > > >
