On 1/30/19 10:19 AM, Ehsan Akhgari wrote:
What tool do you use which has difficulty showing function names in diffs right now? It seems to work fine for me both in git and hgweb...
"hg diff" and "git diff" both fail at this over here when there is a /* comment */ before the function name. hg version 4.4.2 and git version 2.14.5.
For example, if you make a change in the middle of nsContentUtils::AttemptLargeAllocationLoad and then hg diff or git diff, it will claim your change is in nsContentUtils::LookupCustomElementDefinition. I just ran into this while trying to read a patch someone asked for review on.
If there is no comment before the function name, it works. -Boris _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
