On Wed, Jan 30, 2019 at 1:35 AM Karl Tomlinson <mozn...@karlt.net> wrote:
> Ehsan Akhgari writes:
>
> > On Mon, Jan 28, 2019 at 2:58 PM Jeff Gilbert <jgilb...@mozilla.com>
> wrote:
> >
> >> I would much rather revert to:
> >> /*static*/ void
> >> Foo::Bar()
> >>
> >> The Foo::Bar is the most relevant part of that whole expression, which
> >> makes it nice to keep up against the start of the line.
> >>
> >
> > The clang-format option which allows formatting the way you are
> suggesting,
> > AlwaysBreakAfterDefinitionReturnType, is deprecated, and is likely to be
> > removed from a future version of clang-format, so there is no sustainable
> > way for us to adopt this suggestion.
>
> Where there's a will there's often a way. e.g.
>
> /*static*/ void //(clang-format line-break)
> Foo::Bar() {
>
> I do like being able to see function names in diff output, but I'm
> not so keen on having to put //cflb at the beginning of every
> function. This feels too much like working against the decision
> to follow Google style.
>
> With so much code using Google style, I guess there must be tools
> to show useful information in diff output, or at least there will
> be soon...
>
What tool do you use which has difficulty showing function names in diffs
right now? It seems to work fine for me both in git and hgweb...
--
Ehsan
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
