On Tue, Oct 02, 2018 at 03:25:04PM +0300, Henri Sivonen wrote: > On Mon, Sep 24, 2018 at 3:24 PM, Boris Zbarsky <bzbar...@mit.edu> wrote: > > On 9/24/18 4:04 AM, Henri Sivonen wrote: > >> > >> How important is --enable-shared-js? I gather its use case is making > >> builds faster for SpiderMonkey developers. > > > > > > My use case for it is to be able to use the "exclude samples from library X" > > or "collapse library X" tools in profilers (like Instruments) to more easily > > break down profiles into "page JS" and "Gecko things".
I would probably be worthwhile to be able to do that without --enable-shared-js, only because that's not how Nightlies are shipped, and this seems like something that can be useful to do on nightlies. Is grouping by js::* JS* a workable alternative? > On Mon, Sep 24, 2018 at 1:24 PM, Mike Hommey <m...@glandium.org> wrote: > >> How important is --enable-shared-js? I gather its use case is making > >> builds faster for SpiderMonkey developers. Is that the only use case? > > > > for _Gecko_ developers. > > This surprises me. Doesn't the build system take care of not > rebuilding SpiderMonkey if it hasn't been edited? Is this only about > the link time? Yes, it reduces link time for libxul because libmozjs doesn't need to be linked statically to it. That might not matter anymore, but it's better to know if people rely on that. I'd like to note that making libxul always have libmozjs statically linked could allow to move some things from libmozglue to libxul. Mike _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
