(Sorry, I polled #jsapi about this issue back when you first posted and then forgot to reply with the response.)
It doesn't seem like any SM devs use --enable-shared-js for their own development but we do know that various embedders (e.g. GNOME) use the JS shared library and so we'd like to keep that configuration tested and working. One hybrid option is thus: - drop support for building Gecko with --enable-shared-js (avoiding the symbol conflict issue), but keep --enable-shared-js as a configure option for JS shell builds - have at least one tier-1 --enable-shared-js JS shell build on automation so that we at least keep it working Cheers, Luke On Tue, Oct 2, 2018 at 7:25 AM Henri Sivonen <hsivo...@mozilla.com> wrote: > On Mon, Sep 24, 2018 at 3:24 PM, Boris Zbarsky <bzbar...@mit.edu> wrote: > > On 9/24/18 4:04 AM, Henri Sivonen wrote: > >> > >> How important is --enable-shared-js? I gather its use case is making > >> builds faster for SpiderMonkey developers. > > > > > > My use case for it is to be able to use the "exclude samples from > library X" > > or "collapse library X" tools in profilers (like Instruments) to more > easily > > break down profiles into "page JS" and "Gecko things". > > OK. > > On Mon, Sep 24, 2018 at 1:24 PM, Mike Hommey <m...@glandium.org> wrote: > >> How important is --enable-shared-js? I gather its use case is making > >> builds faster for SpiderMonkey developers. Is that the only use case? > > > > for _Gecko_ developers. > > This surprises me. Doesn't the build system take care of not > rebuilding SpiderMonkey if it hasn't been edited? Is this only about > the link time? > > What's the conclusion regarding next steps? Should I introduce > js_-prefixed copies of the four Rust FFI functions that I want to make > available to SpiderMonkey? > > -- > Henri Sivonen > hsivo...@mozilla.com > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
