On Wed, Nov 15, 2017 at 4:31 PM, Boris Zbarsky <bzbar...@mit.edu> wrote: > On 11/15/17 9:12 AM, Henri Sivonen wrote: >> >> How many Mozilla-signed special extensions are there? Does an analog >> of https://dxr.mozilla.org/addons/ exist for searching their code? > That wouldn't have helped in this case. The addon was not using nsIJSON. > The addon was messing up a non-addon global such that that global no longer > had a TextDecoder. Thus when nsIJSON usage in that global (which _is_ > indexed by dxr) was replaced by TextDecoder things failed.
Code search wouldn't have helped *this* case, but considering how useful https://dxr.mozilla.org/addons/ has been previously, the notion of there still existing out-of-tree XPCOM callers but them being dark matter code search-wise worries me. >> Is there a CI system testing that the continue to work? > > > This would have helped in this case, yes. > >> If everything had gone the way things are supposed to go, by what >> mechanism was the breakage from the nsIJSON removal patch supposed to >> have been found before landing? > > > It's not clear that we have such a mechanism right now. :-( -- Henri Sivonen hsivo...@hsivonen.fi https://hsivonen.fi/ _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
