On Tue, Apr 4, 2017 at 5:57 PM, Ehsan Akhgari <ehsan.akhg...@gmail.com> wrote: > I don't own this module any more, so this isn't my call to make, but if > I had to choose what to do here, I would probably either choose to not > change our behavior (since I'm not sure what we're gaining here > concretely -- as AFAIK we're not investing in bringing our behavior on > par with other engines on a more broad basis with regards to editing),
Masayuki seems to be in favor of trying to match Blink more. > or at the lack of that, adding some telemetry first to get data on how > often the defaultParagraphSeparator command is used in the wild, since > AFAICT your change is basically only Web compatible on the assumption > that this command is used quite heavily. I doubt it's used much. My assumption is only that not many sites are UA-sniffing Firefox, finding the <br>s, and modifying them in some way that breaks if they're no longer <br>s. That could still be totally wrong, though! > On the idea of the test plan that Benjamin brought up, I'm not sure what > to put in such a test plan, due to the issue I mentioned above (it being > totally non-obvious what the expected breakage of this change would look > like.) We could put the default defaultParagraphSeparator change behind a pref and leave the pref off on release (or on beta and release?) for some period and see if we get bug reports. I don't think there's any way to detect breakage by telemetry, so we'd have to rely on user reports. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform