On Tue, Aug 23, 2016 at 9:39 AM, R Kent James <k...@caspia.com> wrote: > On 8/21/2016 9:14 PM, Nicholas Nethercote wrote: >> I strongly encourage people to do likewise on >> any IDL files with which they are familiar. Adding appropriate checks isn't >> always easy > > Exactly, and I hope that you and others restrain your exuberance a > little bit for this reason. A warning would be one thing, but a hard > failure that forces developers to drop what they are doing and think > hard about an appropriate check is just having you set YOUR priorities > for people rather than letting people do what might be much more > important work.
I see that I've caused several Thunderbird breakages with the changes I've been making. I apologize for not giving you advance warning about this. I have several desires here. - I want to greatly increase the use of MOZ_MUST_USE/[must_use] in Gecko. - I don't want to make Thunderbird developers' lives more difficult. - I don't want to have to modify comm-central when I add new uses of MOZ_MUST_USE/[must_use] to mozilla-central. The best solution I can see is to insert -Wno-unused-result or -Wno-error=unused-result in the appropriate place(s) in comm-central. Nick _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform