On Saturday, July 9, 2016 at 7:21:24 AM UTC+10, Boris Zbarsky wrote:
> On 7/8/16 4:18 PM, Steve Fink wrote:
> > Are either mxr or dxr really the right thing for canonical links to our
> > source code? As long as we're updating links, through one means or
> > another, temporarily or permanently, couldn't we come up with a set of
> > urls that would be better in the long term? One that clearly states the
> > purpose of a link (eg a link to the latest version of a whole file vs a
> > link to a range of lines in a specific version vs a link to a named
> > function definition or whatever), and could be redirected when the next
> > great thing comes along?
> 
> Yes, please!
> 
> Especially because DXR doesn't allow independent specification of "lines 
> to highlight" and "line to scroll to", so any conversion from mxr links 
> to dxr ones will be somewhat lossy...
> 
> There's still the question of what to back the links with of course 
> (that is, what runs on the server).
> 
> > hg.mozilla.org would seem to be better for versioned links
> 
> Can't highlight lines there, last I checked.
> 
> -Boris

The annotate (aka blame) functionality of hg.mozilla.org can point at one line, 
e.g.:
https://hg.mozilla.org/mozilla-central/annotate/c2da34d96746288b5fee27bf6542a12c9f410988/dom/media/platforms/PDMFactory.cpp#l126
(Hash, lowercase 'L', line number)
I've opened https://bugzil.la/1282329 requesting that DXR generates these as 
recommended permalinks -- Hope you like it. :-)
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to