On Wednesday, June 17, 2015 at 9:57:12 PM UTC-4, Gregory Szorc wrote: > First thing is first: what are the blockers to mass rewriting > mozilla-central with clang-format's output?
For the record I'm in favour of auto-clang-formatting the codebase, but the last time I tried running clang-format on the APZ code [1] there were at least two issues: 1) Comments that exceed the 80-char limit get wrapped blindly, rather than being rewrapped properly. This results in comment blocks that look like this: // This is a comment that was previously just over the eighty // character // limit but got rewrapped by clang-format just blindly // inserting // linebreaks willy-nilly and requires manual fixup. I think this is an issue that should be fixed in clang-format. However, to work around this incrementally I have been manually rewrapping comment blocks in the APZ code if I'm touching them anyway. 2) MOZ_BEGIN_NESTED_ENUM_CLASS seems to trip up the formatter and it misformats the code after that. Cheers, kats [1] https://bugzilla.mozilla.org/show_bug.cgi?id=971970 _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
