On Fri, Nov 28, 2014 at 06:29:49PM +0900, Mike Hommey wrote: > On Fri, Nov 28, 2014 at 12:46:07AM -0800, L. David Baron wrote: > > On Friday 2014-11-28 10:12 +0900, Mike Hommey wrote: > > > The downside from doing so, though, is that non-unified build *will* > > > be broken, and code "purity" (right includes in the right sources, > > > mostly) won't be ensured. Do you think this is important enough to keep > > > non-unified builds around? > > > > Another disadvantage here is that it will make adding or removing > > source files harder, because you'll have to clean up the accumulated > > "nonunified" bustage that shows up when files are shifted around > > between unified files. (This might be somewhat harder to fix a year > > or two later than it is when causing it.) > > Well, if files are shifted around in a what that breaks the build in a > very hard to fix way, it's still possible to adjust moz.build in a way > that avoids the files being shifted around to begin with.
Also note that even with both unified and non-unified builds being green, there are many ways a file shift can trigger build errors. Mike _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
