On 1/27/2014 7:08 PM, Nicholas Nethercote wrote:

It's been a couple of weeks now. Can we move forward?

Anthony Jones has done some work on using clang-format to restyle
lines that have changed in a file, but I don't think anyone has done
any evaluation of clang-format for whole-file changes.

I wonder if we could allow hand-reformatting (e.g.
https://bugzilla.mozilla.org/show_bug.cgi?id=956199), at least for the
moment? Because if we don't allow that, we're stuck in limbo until we
decide on official guidelines for using automatic tools.
Modules owners can *allow* hand reformatting to the style guide any time they want. I don't want to encourage that in the style guide, though.

I would encourage people, rather than doing hand reformatting, to run the clang-format tool on an entire file and identify with the module owner whether it produced useful results. There are still some cases that will need to be fixed by hand after (the CC macros especially). That's the only way we're going to get feedback on clang-format anyway, right?

--BDS

_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to