On Tue, Jan 28, 2014 at 7:15 PM, Anthony Jones <ajo...@mozilla.com> wrote:
> In my opinion clang-format is good enough. > That's awesome! > I haven't received any feedback either positive or negative in relation > to clang-format. That makes it hard for me to know whether to continue > putting any effort into improving it. > I think this is important, and definitely it to get the tool right. > I've tested the whole file reformatting and it seems reasonable to me. > There are some cases it doesn't know anything about like the indenting > associated with macros such as NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN and > NS_IMPL_CYCLE_COLLECTION_UNLINK_END. > Do we have a path to fix it? There is also some vagueness and inconsistency around: > > bool > MyClass::MyFunction() > > vs > > bool MyClass::MyFunction() > I'm pretty sure the former is correct per Gecko style. Benjamin can confirm. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
