2014/1/7 L. David Baron <dba...@dbaron.org> > On Tuesday 2014-01-07 09:13 +0100, Ms2ger wrote: > > On 01/07/2014 01:11 AM, Joshua Cranmer 🐧 wrote: > > >Since Benjamin's message of November 22: > > ><news:// > news.mozilla.org/mailman.11861.1385151580.23840.dev-platf...@lists.mozilla.org > > > > >(search for "Please use NS_WARN_IF instead of NS_ENSURE_SUCCESS" if you > > >don't have an NNTP client). Although there wasn't any prior discussion > > >of the wisdom of this change, whether or not to use > > >NS_ENSURE_SUCCESS-like patterns has been the subject of very acrimonious > > >debates in the past and given the voluminous discussion on style guides > > >in recent times, I'm not particularly inclined to start yet another one. > > > > FWIW, I've never seen much support for this change from anyone else > > than Benjamin, and only in his modules the NS_ENSURE_* macros have > > been effectively deprecated. > > I'm happy about getting rid of NS_ENSURE_*. >
I would like a random voice in favor of deprecating NS_ENSURE_* for the reason that hiding control flow behind macros is IMO one of the most evil usage patterns of macros. Benoit > > -David > > -- > 𝄞 L. David Baron http://dbaron.org/ 𝄂 > 𝄢 Mozilla https://www.mozilla.org/ 𝄂 > Before I built a wall I'd ask to know > What I was walling in or walling out, > And to whom I was like to give offense. > - Robert Frost, Mending Wall (1914) > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform