I support getting rid of NS_ENSURE_*. Gavin
On Tue, Jan 7, 2014 at 3:13 AM, Ms2ger <ms2...@gmail.com> wrote: > On 01/07/2014 01:11 AM, Joshua Cranmer 🐧 wrote: >> >> On 1/6/2014 6:06 PM, smaug wrote: >>> >>> On 01/07/2014 01:38 AM, Joshua Cranmer 🐧 wrote: >>>> >>>> On 1/6/2014 4:27 PM, Robert O'Callahan wrote: >>>>> >>>>> That's just not true, sorry. If some module owner decides to keep >>>>> using NULL or PRUnichar, or invent their own string class, they will >>>>> be corrected. >>>> >>>> >>>> Maybe. But we also have a very large number of deprecated or >>>> effectively-deprecated constructs whose deprecation module owners may >>>> not be aware of >>>> because their use is somewhat prevalent in code. For example, the >>>> NS_ENSURE_* macros are apparently now considered officially deprecated. >>> >>> Since when? NS_ENSURE_ macros are very useful for debugging. (When >>> something is going wrong, the warnings in the terminal tend to give >>> strong >>> hints what/where that something is. Reduces debugging time >>> significantly.) >> >> >> Since Benjamin's message of November 22: >> >> <news://news.mozilla.org/mailman.11861.1385151580.23840.dev-platf...@lists.mozilla.org> >> (search for "Please use NS_WARN_IF instead of NS_ENSURE_SUCCESS" if you >> don't have an NNTP client). Although there wasn't any prior discussion >> of the wisdom of this change, whether or not to use >> NS_ENSURE_SUCCESS-like patterns has been the subject of very acrimonious >> debates in the past and given the voluminous discussion on style guides >> in recent times, I'm not particularly inclined to start yet another one. > > > FWIW, I've never seen much support for this change from anyone else than > Benjamin, and only in his modules the NS_ENSURE_* macros have been > effectively deprecated. > > HTH > Ms2ger > > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
