On 1/2/13 9:11 PM, Boris Zbarsky wrote:
On 1/2/13 4:44 PM, Benjamin Smedberg wrote:
Was this particular logging enabled with NSPR_LOG_MODULES=all:5
No.
The failure mode was that if you enabled logging for any module at all
we would crash at shutdown because there was an NS_WARNING after
poisoning happened (from NS_ENSURE_SOMETHING_OR_OTHER) and NS_WARNING
always got logged into the log, no matter what module you were logging.
Do we know why this was happening? The log module specifies "nsDebug",
and it should only be written to the log if PR_LOG_MODULES includes
"nsDebug".
What this patch is basically saying is that it's a bug to use NSPR
logging after early shutdown. I don't think that's reasonable, and I
think we should spend time trying to make NSPR logging work correctly.
That the NS_* debug spew shows up in the NSPR logs all the time seems
like a separate bug which we should also fix, but I suspect that having
the existing debug spew mixed into the NSPR logs may be useful for some
people (I've certainly used it in the past) and I'm loathe to remove it
as a bandaid for the real problems.
--BDS
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
