----- Original Message ----- > There are potentially lots of ways to cause logging to happen after > poisoning is enabled. I don't understand why we shouldn't instead > whitelist logging as ok during shutdown.
The whitelist technique that has been used for other files, e.g. whitelisting particular file descriptors: http://mxr.mozilla.org/mozilla-central/source/xpcom/build/mozPoisonWriteMac.cpp#380 can't be used with NSPR logging because we don't have access to the FILE* or file descriptor that's used for the logging file. > Was this particular logging enabled with NSPR_LOG_MODULES=all:5 or > how > in particular did we end up enabling logging for webrtc tests in > particular that wouldn't have affected many of the other logging > modules? I see that bug 811764 has been resolved in a different way, so the combination of logging and write poisoning wasn't responsible for the WebRTC failures. But the problem still remains in other contexts, especially developers using logging themselves to figure out what's going on, whether in personal builds or release builds. -Nathan _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
