On 1/2/2013 2:34 PM, Nathan Froyd wrote:
Hi all,
Over in bug 794178, we're hitting cases where the combination of write
poisoning (crashing if writes to disk are detected after a certain point) and
logging are causes crashes. These same crashes are blocking testing for WebRTC
(bug 811764). The root cause is that the warnings emitted by NS_* macros such
as NS_ENSURE_TRUE are written to the debug log if one exists. David Baron has
approved a patch[1] that removes the problematic logging.
If you have objections to this change, please speak up, either here or in bug
794178. Otherwise, the patch that removes the logging will be committed later
this week.
There are potentially lots of ways to cause logging to happen after
poisoning is enabled. I don't understand why we shouldn't instead
whitelist logging as ok during shutdown.
Was this particular logging enabled with NSPR_LOG_MODULES=all:5 or how
in particular did we end up enabling logging for webrtc tests in
particular that wouldn't have affected many of the other logging modules?
I don't think this is the correct choice.
--BDS
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
