Branden Robinson wrote:
>
> On Fri, Jun 29, 2001 at 04:22:01AM +0200, Michel Dänzer wrote:
> > Branden Robinson wrote:
> > >
> > > I'd like feedback on these packages, please, to the debian-x list.
> >
> > DRI is for Direct Rendering Infrastructure, not Interface.
>
> Whoops. And usually I'm such a stickler for correct terminology. I'll
> update the template.
Thanks.
> > It seems you have applied my r128 Xv endianness fix, why don't you mention
> > it in the changelog?
>
> Because I am inconsistent about which ones I'm mentioning. Strictly
> speaking, I should redescribe all the patches because they've been
> renumbered, but that strikes me as excessive.
Okay. The most important things is that the patch is applied.
> > And why don't you apply the Dashed Bresenham fix as well?
>
> Because I forgot about it, and don't know where it is.
Attached to this mail, for example. :)
> > Also, some kind of patch adding -fPIC for building static libraries will
> > have to be applied, or a lot of shared libraries will break on powerpc.
>
> Gotta build *static* libraries with this flag so *shared* libs won't
> break...got it. I'll dig around in xc/config/cf/linux.cf and see if
> there's something I can diddle for that.
>
> I'm not sure which would be a greater mark of insanity: wanting to
> understand why, or not wanting to.
It's very easy actually. The static libs get linked into shared libs, so they
sort of become shared libs as well.
> > There have been a few posts about the problem to -powerpc (related to
> > xmms and SDL), and a possible solution is being discussed on
> > devel@XFree86.Org .
>
> Okay, I'll grep through there.
My patch there should do IMHO, but I'd like to get some confirmation from the
core team.
> Do you want an xserver-xfree86 debconf question for "UseFBDev"? I only
> need to ask if [ -d /dev/fb ], correct?
/proc/fb is better, /dev/fb* should be there on any Debian system (at least
those not running devfs). "UseFBDev" should never hurt though.
--
Earthling Michel Dänzer (MrCooper) \ Debian GNU/Linux (powerpc) developer
CS student, Free Software enthusiast \ XFree86 and DRI project member
Index: programs/Xserver/hw/xfree86/drivers/ati/r128_accel.c
===================================================================
RCS file: /cvs/xc/programs/Xserver/hw/xfree86/drivers/ati/r128_accel.c,v
retrieving revision 1.9
diff -u -r1.9 r128_accel.c
--- r128_accel.c 2001/04/10 16:07:58 1.9
+++ r128_accel.c 2001/06/15 13:39:45
@@ -408,11 +408,17 @@
R128CCE_TO_MMIO(pScrn, info);
#endif
+#if X_BYTE_ORDER == X_LITTLE_ENDIAN
+# define PAT_SHIFT(pat,n) pat << n
+#else
+# define PAT_SHIFT(pat,n) pat >> n
+#endif
+
switch (length) {
- case 2: pat |= pat << 2; /* fall through */
- case 4: pat |= pat << 4; /* fall through */
- case 8: pat |= pat << 8; /* fall through */
- case 16: pat |= pat << 16;
+ case 2: pat |= PAT_SHIFT(pat,2); /* fall through */
+ case 4: pat |= PAT_SHIFT(pat,4); /* fall through */
+ case 8: pat |= PAT_SHIFT(pat,8); /* fall through */
+ case 16: pat |= PAT_SHIFT(pat,16);
}
R128WaitForFifo(pScrn, 5);
