On Sun, Feb 2, 2014 at 2:01 AM, Joseph Herlant <herla...@gmail.com> wrote:
> Dear Vincent,
>
> I first understood that I needed --with quilt and then lintian was
> complaining about a missing build-dep for quilt. That's why I added
> them.
> But I doubled checked, tested on the package and you're right I don't
> need this! <:-)
> That's great, I removed them.
Source format '3.0 (quilt)' means that dpkg-source will automatically
deal with (un-)applying patches, so you don't need to use
dh_quilt_{patch,unpatch} to do so. If you were using an older source
format (e.g. 1.0), then yes, you would need to explicitly declare a
build-dep on quilt.
> Yep, you guessed why priority was extra: I let them to the default
> value of dh_make. Changed that! :-)
>
> I didn't know this wrap-and-sort script. This is a great tool in its
> way! It even cleans up the commented Vcs-*! :-D
>
> Thanks a lot for all your help and time. I know feel I have a pretty
> awesome package thanks to you! ;-)
>
> I have to make a big sticky note with all your advises for next
> package with a lot of smileys!
Great, thanks for fixing all those rather pedantic complaints!
One last nitpick (sorry!) is that other gnome-shell extensions
packaged in Debian seem to prefix their packages with
"gnome-shell-extension-" (e.g. gnome-shell-extension-weather,
gnome-shell-extension-autohidetopbar), so can you please do the same
for your binary package as well, i.e. rename it
gnome-shell-extension-pomodoro?
Vincent
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/caczd_tbgzrhvmilk-zrq8bx2xcoudsqekw9v4hlkqnhyfrz...@mail.gmail.com
