On Thu, Jan 30, 2014 at 12:25 PM, Joseph Herlant <herla...@gmail.com> wrote: > Hi Vincent, > > Thanks for this advice. :-) > > I chose to use the patching approach because I found it cleaner (and > wanted to play with quilt once again!). > I recreated the package from the upstream 0.8 tag and used quilt to > integrate the fixes in one patch. > Package have been uploaded to mentors. > Please tell me if you have remarks.
You're already using source format '3.0 (quilt)', so please remove the extraneous build-dep on quilt and the "--with quilt" invocation in d/rules. Some more extra pedantic comments: - Why priority: extra instead of optional? Most packages should be set to optional by default (yes, I'm aware dh_make uses priority: extra as default for some reason) unless they conflict with packages of higher priority (Policy 2.5). - Please use "wrap-and-sort -s" from devscripts to have your build-deps and deps in d/control listed one per line and in alphabetical order (this generally makes it a _lot_ easier to review changes to build-dep/dep fields in d/control). - Consider removing the commented lines (the unused Vcs-* fields) in d/control I've run out of things to nitpick, so I think that means your package is about ready to be uploaded. ;) Cheers, Vincent -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caczd_tbpub7srq3-8j0odtcjx2mktmyozxwrjpjs4nrbwfr...@mail.gmail.com
