On Wed, Jan 29, 2014 at 12:59 PM, Joseph Herlant <herla...@gmail.com> wrote: > retitle 728059 RFS: gnome-shell-pomodoro/0.8.0-1 [ITP] > thanks > > > Dear Vincent, > > Thanks a lot for your advises and your time. > > > >> Yes, use "all" instead. "any" will cause your package to be compiled >> on all Debian release architectures and introduce different binary >> packages of gnome-shell-pomodoro for every supported arch; "all" will >> save buildd time and will only install a single binary package for use >> on all archs. > > I now understand the difference. Thanks a lot. > I updated the package to use all. > > > >> It still doesn't abide by devref guidelines though; you should remove >> "This" and the period at the end of your synopsis (devref 6.2.2 [1]). >> Also, your description has a few other minor issues (e.g. inconsistent >> capitalization of "Pomodoro Technique". You may wish to ask for a >> review of your package synopsis and description via >> debian-l10n-engl...@lists.debian.org (at this point I'm just being >> pedantic, so ignore this if you want, I suppose, but ideally fix the >> synopsis at least). > > That was a really really good advice. It helped me a lot. Thanks. :-) > The description and synopsis have been reviewed. > > >> Please merge your changelog entries into a single one (version >> 0.8.0-1). You also don't need to reference me in your changelog entry. >> :) > > I merged everything to keep the version 0.8.0-1. You can find the dsc file at: > http://mentors.debian.net/debian/pool/main/g/gnome-shell-pomodoro/gnome-shell-pomodoro_0.8.0-1.dsc > > >> Also, gnome-shell-pomodoro should not depend on intltool and >> libglib2.0-dev. Those packages are needed to build >> gnome-shell-pomodoro (hence why they are listed in build-depends), but >> not for running g-s-pomodoro itself. > > Absolutely right. I updated that! :-) > > > > Note that after discussing with the upstream author it seems that > after a mistake, the compatibility of gnome-shell between 0.8.0 and > 0.8.1 have been broken (gnome-shell 3.8 not supported anymore on > 0.8.1) so fixes cannot be applied as a new tag. > So I updated the package binaries using the latest fixes from the > branch supporting gnome-shell 3.8. > I installed it, played with it a little and found no issue.
This means that your source tarball's hashsum doesn't match upstream's tarball anymore, of course: c937a8509bb6cfae596ed459c907e299 gnome-shell-pomodoro_0.8.0.orig.tar.gz e64dc07ed8ef238a566f69ffa4796eae gnome-shell-pomodoro-0.8.tar.gz If you have to repack a tarball for whatever reason (the most common reason is to strip out non-DFSG compatible files), you should have a get-orig-source target in debian/rules (Policy 4.9), and your package version in d/changelog should have some hint that your 0.8.0 version is not the same as 0.8.0 upstream (again, for DFSG purposes, the version number usually has "+dfsg" appended to it; if you're pulling directly from upstream git, a fairly common approach is to include the timestamp in the version). Alternatively, you can also just use upstream's github tarball and then apply the changes in the gnome-3.8 branch upstream as a patch (ideally with a DEP-3 header) in your package. Regards, Vincent -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caczd_tage-+iqfq1mrjtgu2qb+tnsftfhu-nr0ov9h1o0ik...@mail.gmail.com
