Hi Daniel,
Thanks for your recent corrections. Just few more left to do and I'll
upload for you.
* When I mentioned "unnecessary versioned dependencies" I meant that
versioning is unnecessary and safe to drop. There is no point
writing "cmake (>= 2.8.2+dfsg.1-0+squeeze1)" when just "cmake" is
enough because cmake in oldstable is above minimum requirement.
Same applies to "libqt4-dev".
* Short package description should start with lowercase letter.
Copyright:
* Upstream uses two emails in source files:
Joseph Artsimovich <joseph.artsimov...@gmail.com>
Joseph Artsimovich <josep...@mail.ru>
The latter statement appears to be older (it is often accompanied
by years 2007-2008 and one would hardly use this horrible russian
email service while having account at gmail).
I would at least mention first statement (i.e. contact email) in
Upstream-Contact or even include both statement to copyright
paragraph as it would be speculative to decide which statement is
more important/valid.
* The following copyright holders are not listed in debian/copyright:
Vadim Kuznetsov ()DikBSD <dik...@gmail.com>
2011 Petr Kovar <pej...@gmail.com>
* "Based on code from the GIMP project" is not a copyright statement
so perhaps it's better to move it to Comment section. Then it would
become obvious that word "Copyright" is used twice in the
paragraph.
* At least one file in "packaging/osx" is under BOOST license. Also
file "ScanTailor.icns" is a (sourceless?) binary file...
* "License: PD" perhaps is better written as
"License: public-domain".
For files in Public-Domain copyright is not applicable so it is
better to write "Copyright: not-applicable" but mention origin of
files (i.e. Tango project and URL) in Comment field.
* One of the man pages is written by "Artem Popov <art...@gmail.com>"
but that's not how his name is written in debian/copyright. It is
always safer to use original statement as written by author without
unnecessary translation of person's name to native characters even
if it is done correctly.
* Generated man page is not removed on clean.
Probably you don't need this reminder but when convenient please
forward patch and man pages to upstream.
Thanks for your patience. Correcting the above issues will increase
our chances to pass ftp-master's review.
Cheers,
Dmitry Smirnov.
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/201306200642.13719.only...@debian.org
