On Wed, 19 Jun 2013 03:25:05 Daniel Stender wrote:
> 1) buildflags.patch / build type
>
> First of all, the patch works fine. Actually, after removing the
> forced variable overrides Cmake recognizes already the standard
> environment build flags.
Great, thanks for checking. :)
> I've came across that Debhelper 20130504 was set to always switch to
> RelWithDebInfo build type (#701233), which yes puts -DNDEBUG into
> building on current Sid (Debhelper 20130605) - are there different
> opinions on that issue?
It is great than debhelper became better with cmake. From my past
experience with cmake I might be a bit traumatised by weird upstream
scripts that strip executables in "Release" mode. However explicitly
passing build type may be advantages in some cases. It does not hide
logic and allows to set proper corresponding CMAKE variables that are
specific to build type. Concerning backportability it would be even
preferable to explicitly set build type to produce reliable and
predictable build results.
For "scantailor" I have no preference and leave decision to maintainer.
> 2) hardening of scantailor-cli
>
> As another issue remains that scantailor-cli still doesn't got fortified:
>
> $ hardening-check scantailor-cli
As far as I'm aware `hardening-check` might produce incorrect
results. When I check build logs with `blhc` it prints no warnings
whatsoever which is an evidence that all executables compiled will
hardening flags so IMHO we're all good here.
Here is another minor improvement suggestion: there are some
unnecessary versioned build-dependencies on
* "cmake (>= 2.6.0)": oldest is 2.8.2+dfsg.1-0+squeeze1
* "libqt4-dev (>= 4.4.0)": oldest is 4:4.6.3-4+squeeze1
Also I'd set source archive and .DEB files compression to xz:
Source compression can be set in "debian/source/options" by adding
compression = "xz"
.DEB file compression can be set in "debian/rules" by adding
override_dh_builddeb:
dh_builddeb -- -Zxz
I'll have yet another look at the package tonight.
Thanks.
Cheers,
Dmitry Smirnov.
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/201306192009.50634.only...@debian.org
