-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Dimitry,
much thanks for the review of my package. I've proceeded so far: 1) copyright * fixed > * regarding copyright, notation "Files: ./crash_reporter/google-breakpad/*" > is a bit strange > as there is no need to prefix file paths with "./" > > * In "Copyright: 2006-2008 Google Inc." paragraph license "other" is > incorrect -- it is a > "BSD-2-clause" license. > > * In "Copyright: 2005-2007 Paul Hsieh" paragraph license "other" is incorrect > -- it looks like > modified "BSD-3-clause" license, so perhaps it might be better to mark it > something like > "BSD-3-clause(modified)" and/or add a comment. Fixed (google-breakpad as BSD-3-clause). 2) lintian-overrides * fixed > * Please do not override "no-upstream-changelog". Lack of upstream changelog > is a genuine > (minor) problem isn't it? Silencing legitimate warnings is not a good idea, > especially when > you do it without corresponding comment about why the warning was suppressed > in > lintian-overrides. > * I: scantailor: unused-override hardening -no-fortify-functions > usr/bin/scantailor-cli I've removed the overrides completely. 3) buildflags > * buildflags.patch is incorrect because it is hardcoding FLAGS. To make it > useful upstream you > could modify cmake to avoid overriding CXXFLAGS and then pass build flags > like in the following > example: > > override_dh_auto_configure: dh_auto_configure -- \ > -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo \ > -DCMAKE_CXX_FLAGS_RELWITHDEBINFO="$(CPPFLAGS)" \ -DCMAKE_EXE_LINKER_FLAGS=" > -Wl,--as-needed > $(LDFLAGS)" > * Passing build flags requires more work as there are still some FLAGS > missing, according to > `blhc`: > > CXXFLAGS missing (-fstack-protector --param=ssp-buffer-size=4 -Wformat > -Werror=format-security) I've removed the patch and created an override for auto configure. Nevertheless, passing the build flags stays problematic. The Cmake invokes with fully expanded buildflag variables (I've added CXXFLAGS): <cut> cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo - -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo "-DCMAKE_CXX_FLAGS_RELWITHDEBINFO=-g -O2 - -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2" "-DCMAKE_EXE_LINKER_FLAGS= -Wl,--as-needed -Wl,-z,relro" </cut> But Scantailor gets compiled w/o any customization, running the Cmake standard build flags: <cut> /usr/lib/ccache/c++ -DBOOST_MULTI_INDEX_DISABLE_SERIALIZATION -DBOOST_TEST_DYN_LINK - -D_BIND_TO_CURRENT_VCLIBS_VERSION=1 -Wall -Wno-unused -ffast-math -DNDEBUG -g -O2 - -fvisibility=hidden -I/tmp/buildd/scantailor-0.9.11.1/. <...> </cut> Anyway, the custom linker flags got passed through! I've experimented around, e.g. dropping the build type switch, but couldn't got a clue why this isn't working that way, is it? For recent changes, please cf.: http://anonscm.debian.org/gitweb/?p=collab-maint/scantailor.git Build log: http://www.danielstender.com/uploads/scantailor_0.9.11.1-1_amd64.build Mucht thanks also for the other comments! Greetings, Daniel Stender - -- http://www.danielstender.com/blog/ GPG key ID: 1654BD9C -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iEYEARECAAYFAlG8hUsACgkQU8fCMhZUvZyKqACdGxpJtcEGSTICZV5ZiiieJm2O z4sAn2jSeJUlo0Fy0VYglfqzF9TUEqou =Bo6n -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/51bc854e.2080...@danielstender.com
