Control: tags -1 - moreinfo > On Sun, 6 Jan 2013 12:04:41 +0100 > Helmut Grohne <hel...@subdivi.de> wrote: >
Thank you very much for the suggestions. > On Fri, Nov 30, 2012 at 12:13:16AM -0800, Dima Kogan wrote: > > dget -x > > http://mentors.debian.net/debian/pool/main/t/tcpflow/tcpflow_1.3.0-1.dsc > > I suggest to target experimental instead of sid, because the package is > part of wheezy. Agreed. Done. > The changelog is not very verbose. Please extend. For instance you bump > the Standards-Version but do not mention which (if any) changes were > needed for that. Similarly I'd expect the conversion of debian/copyright > to be mentioned. Reasons for adding or dropping patches would be nice, > too. I added some detail, but maybe even more woudl be better. Most of the packaging work was simply bringing it up to date, so there wasn't a lot that was actually interesting to describe. > Can you check whether Multi-Arch: foreign is applicable to the tcpflow > binary package? I don't follow. The docs suggest that 'Multi-Arch: foreign' is for dependencies that can satisfy the depender of any architecture. Tcpflow isn't a library and it's not a 'common' part of anything. Does this apply here? > Just a stylistic hint you can choose to ignore: Instead of overriding > dh_auto_clean, you can mention files to be deleted in debian/clean which > will be picked up by dh_clean. Great idea. Done. > The debian/copyright information appear to be incomplete and wrong. The > main license file contains the GPL-3 whereas debian/copyright claims > GPL-1. In addition the source ships a mp5.c within public domain and a > header from the glibc both of which can be down-licensed as GPL-3. > Nevertheless it would be nice to have them mentioned in debian/copyright > explicitly. You also dropped the previous authors for debian/* content. > This license issues are why I tag the RFS as moreinfo. Please remove the > tag after fixing. Thanks for checking this. I was simply using the pre-fork copyrights, which turned out to be very incomplete. This was my fault, and the copyright file should be mostly good now. The only possibly-wrong piece is the way the public domain sources are specified. I'm specifying a "Public domain" license and omitting the Copyright. Lintian doesn't think this is right, but I'm not sure how to do this better. There was also a non-DFSG-compliant file that wasn't being used, so I repacked the source without it. > Instead of invoking boostrap.sh and cleaning the configure stuff you > might be able to just use dh-autoreconf. I did not verify whether this > works. This does indeed work, and I'm now doing this. Thanks. Again, thanks for the review. An updated package tree is at git://git.debian.org/git/users/dkogan-guest/tcpflow.git It will move to collab-maint when they add me to their group. The package did find a sponsor (Paul Tagliamonte), so hopefully it'll make it into experimental soon. Thanks again. dima -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130202025049.278a8593@shorty.local
