Control: tags -1 moreinfo On Fri, Nov 30, 2012 at 12:13:16AM -0800, Dima Kogan wrote: > dget -x > http://mentors.debian.net/debian/pool/main/t/tcpflow/tcpflow_1.3.0-1.dsc
I suggest to target experimental instead of sid, because the package is part of wheezy. The changelog is not very verbose. Please extend. For instance you bump the Standards-Version but do not mention which (if any) changes were needed for that. Similarly I'd expect the conversion of debian/copyright to be mentioned. Reasons for adding or dropping patches would be nice, too. Can you check whether Multi-Arch: foreign is applicable to the tcpflow binary package? Just a stylistic hint you can choose to ignore: Instead of overriding dh_auto_clean, you can mention files to be deleted in debian/clean which will be picked up by dh_clean. The debian/copyright information appear to be incomplete and wrong. The main license file contains the GPL-3 whereas debian/copyright claims GPL-1. In addition the source ships a mp5.c within public domain and a header from the glibc both of which can be down-licensed as GPL-3. Nevertheless it would be nice to have them mentioned in debian/copyright explicitly. You also dropped the previous authors for debian/* content. This license issues are why I tag the RFS as moreinfo. Please remove the tag after fixing. Instead of invoking boostrap.sh and cleaning the configure stuff you might be able to just use dh-autoreconf. I did not verify whether this works. Helmut -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130106110441.ga3...@alf.mars
