Control: tags -1 +moreinfo

Glenn,

Preamble...

Thank you for taking the time to prepare this package and your contribution to
the Debian project.

This review is offered to help package submitters to Debian mentors inorder to
improve their packages prior to possible sponsorship into Debian. There is no
obligation on behalf of the submitter to make any alterations based upon
information provided in the review.


Review...


1. Build:

  * pbuilder [1]: Good
 
  * sbuild [2]: Good


2. Lintian [3]: Issue

I: lighttpd source: rules-silently-require-root lighttpd (www-data:www-data)
var/cache/lighttpd/ [debian/control:41]
N: 
N:   These sources require fakeroot(1) or similar to build the installation
N:   packages, but the field Rules-Requires-Root is empty or missing.
N:   
N:   At least the shown path in the indicated installation package is owned by
N:   user (or a group) other than root:root.
N:   
N:   Over time, Debian has successively narrowed the steps for which elevated
N:   privileges are required. It speeds up the building of installation
N:   packages in the archive.
N:   
N:   Please declare whether the sources require root privileges. Eventually,
N:   Debian will switch the default archive-wide behaviour to expedite the
N:   build process.
N:   
N:   You can use the field Rules-Requires-Root in the source stanza of
N:   debian/control to declare the required build privileges.
N: 
N:   Please refer to usr/share/doc/dpkg/spec/rootless-builds.txt, debian/rules
N:   and Rules-Requires-Root (Section 4.9.2) in the Debian Policy Manual, and
N:   Rules-Requires-Root (Section 5.6.31) in the Debian Policy Manual for
N:   details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: debian/control/field/rules-requires-root
N:   Renamed from: should-specify-rules-requires-root
N: 


P: lighttpd: manual-page-for-system-command [usr/sbin/lighty-enable-mod]
N: 
N:   The command in /sbin or /usr/sbin are system administration commands;
N:   their manual pages thus belong in section 8, not section 1.
N:   
N:   Please check whether the command is actually useful to non-privileged user
N:   in which case it should be moved to /bin or /usr/bin, or alternatively the
N:   manual page should be moved to section 8 instead, ie. /usr/share/man/man8.
N: 
N:   Please refer to Bug#348864, Bug#253011, and the hier(7) manual page for
N:   details.
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: documentation/manual
N:   Renamed from: command-in-sbin-has-manpage-in-incorrect-section
N:


P: lighttpd source: package-uses-old-debhelper-compat-version 12
N: 
N:   This package uses a debhelper compatibility level that is no longer
N:   recommended. Please consider using the recommended level.
N:   
N:   For most packages, the best way to set the compatibility level is to
N:   specify debhelper-compat (= X) as a Build-Depends in debian/control. You
N:   can also use the debian/compat file or export DH_COMPAT in debian/rules.
N:   
N:   If no level is selected debhelper defaults to level 1, which is
N:   deprecated.
N: 
N:   Please refer to the debhelper(7) manual page for details.
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: debhelper

E: Lintian run failed (runtime error)


3. Licenses [4]: Issue

philwyett@ks-tarkin:~/Development/builder/debian/lighttpd$ lrc
en: Versions: recon '3.4'  check '3.3.9-1'

Parsing Source Tree  ....
Reading d/copyright  ....
  Missing Files: Paragraph for debian/
Running licensecheck ....

d/copyright      | licensecheck

BSD-3-clause     | GPL-1             debian/lighty-enable-mod

File states:

#       You may distribute under the terms of either the GNU General Public
#       License[1] or the Artistic License[2].


4. Watch file [uscan --force-download]: Good


5. Build Twice (build source after successful build [1]: Good


6. Reproducible builds [5]: Good


7. Tail of the ratt [6]: Good

philwyett@ks-tarkin:~/Development/builder/debian$ ratt --dist=trixie
lighttpd_1.4.77-1_amd64.changes 
2025/01/22 22:14:51 Loading changes file "lighttpd_1.4.77-1_amd64.changes"
2025/01/22 22:14:51  - 35 binary packages: lighttpd lighttpd-dbgsym lighttpd-
doc lighttpd-mod-authn-gssapi lighttpd-mod-authn-gssapi-dbgsym lighttpd-mod-
authn-pam lighttpd-mod-authn-pam-dbgsym lighttpd-mod-authn-sasl lighttpd-mod-
authn-sasl-dbgsym lighttpd-mod-deflate lighttpd-mod-deflate-dbgsym lighttpd-
mod-gnutls lighttpd-mod-gnutls-dbgsym lighttpd-mod-maxminddb lighttpd-mod-
maxminddb-dbgsym lighttpd-mod-mbedtls lighttpd-mod-mbedtls-dbgsym lighttpd-mod-
nss lighttpd-mod-nss-dbgsym lighttpd-mod-openssl lighttpd-mod-openssl-dbgsym
lighttpd-mod-vhostdb-pgsql lighttpd-mod-vhostdb-pgsql-dbgsym lighttpd-mod-
webdav lighttpd-mod-webdav-dbgsym lighttpd-mod-wolfssl lighttpd-mod-wolfssl-
dbgsym lighttpd-modules-dbi lighttpd-modules-dbi-dbgsym lighttpd-modules-ldap
lighttpd-modules-ldap-dbgsym lighttpd-modules-lua lighttpd-modules-lua-dbgsym
lighttpd-modules-mysql lighttpd-modules-mysql-dbgsym
2025/01/22 22:14:51 Corresponding .debs (will be injected when building):
2025/01/22 22:14:51     lighttpd-dbgsym_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-doc_1.4.77-1_all.deb
2025/01/22 22:14:51     lighttpd-mod-authn-gssapi-dbgsym_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-authn-gssapi_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-authn-pam-dbgsym_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-authn-pam_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-authn-sasl-dbgsym_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-authn-sasl_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-deflate-dbgsym_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-deflate_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-gnutls-dbgsym_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-gnutls_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-maxminddb-dbgsym_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-maxminddb_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-mbedtls-dbgsym_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-mbedtls_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-nss-dbgsym_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-nss_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-openssl-dbgsym_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-openssl_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-vhostdb-pgsql-dbgsym_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-vhostdb-pgsql_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-webdav-dbgsym_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-webdav_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-wolfssl-dbgsym_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-mod-wolfssl_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-modules-dbi-dbgsym_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-modules-dbi_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-modules-ldap-dbgsym_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-modules-ldap_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-modules-lua-dbgsym_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-modules-lua_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-modules-mysql-dbgsym_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd-modules-mysql_1.4.77-1_amd64.deb
2025/01/22 22:14:51     lighttpd_1.4.77-1_amd64.deb
2025/01/22 22:14:52 Figuring out reverse build dependencies using dose-ceve(1).
This might take a while
2025/01/22 22:23:58 Found 10 reverse build dependencies
2025/01/22 22:23:58 Setting -sbuild_dist=unstable (from .changes file)
2025/01/22 22:23:58 Building package 1 of 10: genparse 
2025/01/22 22:27:32 Building package 2 of 10: privoxy 
2025/01/22 22:33:23 Building package 3 of 10: pyhoca-cli 
2025/01/22 22:34:42 Building package 4 of 10: slurm-wlm 
2025/01/22 22:41:26 Building package 5 of 10: daisy-player 
2025/01/22 22:42:35 Building package 6 of 10: libiio 
2025/01/22 22:44:38 Building package 7 of 10: libreswan 
2025/01/22 22:46:31 Building package 8 of 10: latex2rtf 
2025/01/22 22:49:36 Building package 9 of 10: html-xml-utils 
2025/01/22 22:52:03 Building package 10 of 10: mini-buildd 
2025/01/22 22:54:35 Build results:
2025/01/22 22:54:35 PASSED: daisy-player
2025/01/22 22:54:35 PASSED: libiio
2025/01/22 22:54:35 PASSED: html-xml-utils
2025/01/22 22:54:35 PASSED: pyhoca-cli
2025/01/22 22:54:35 PASSED: slurm-wlm
2025/01/22 22:54:35 PASSED: libreswan
2025/01/22 22:54:35 PASSED: latex2rtf
2025/01/22 22:54:35 PASSED: mini-buildd
2025/01/22 22:54:35 PASSED: genparse
2025/01/22 22:54:35 PASSED: privoxy


8. Install [No previous installs]: Good


9. Upgrade [Over previous installs if any]: Good


Summary...

I believe 'lighthttpd' is not yet ready for sponsorship at this time. Could the
contributor rectify one of more of the raised issues.

Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug report.

To remove 'moreinfo' tag, add below line to top of email replying to bug report
when a new upload is made.

Control: tags -1 -moreinfo


Please try the below on your packages...

[1] pbuilder:

  * Command for 1.: sudo pbuilder build <PACKAGE>.dsc
  * Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks


[2] sbuild:

  * Command: sbuild -d unstable <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild


[3] lintian:

  * Command: lintian --display-info --verbose --fail-on error --info --pedantic
--show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different
results, so be thorough.
  * Document: https://wiki.debian.org/Lintian


[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

  Note: Please report false positives as bug reports against 'licenserecon'

Reply via email to