Hi Ko Ko Ye`, thanks for the update.
On Sun, Nov 17, 2024 at 06:58:02AM +1100, Ko Ko Ye` wrote: > Hi Tobias and mentors > > > - d/changelog is missing entries from old uploads. don't drop them! > Restore. > > My mistake. > > - there are changes to the packaging NOT documented in d/changelog, > changelog update. Thanks. Please drop the references to the upstream bugs, they make no sense in the context of the d/changelog. Regarding the change to ignore-patterns, can you expand *why* you need this change? I have a feeling that whatever you want to archive, this is not the correct way. > - It seems that the changes are all stuffed into the single new patch, > the next version will be a new release. > patches: > - keyboard-support.patch > - webcam-support.patch > - appstream-metadata.patch Why don't cut a release now? Regarding the dep3 headers, appstream-metadata.patch seems to refer to the wrong upstream issue? (It points to the same as keyboard-support.patch.) The metadata says "Applied-Upstream: 0.3-2". Well, 0.3-2 is a *Debian* version with upstream version being 0.3 and the Debian (package) revision being -2. (If you are unsure how the Debian package version is made up, please consult Policy §5.6.12) So marking Applied-Upstream with a Debian-package revision does not really make sense. > - W: wifi-qr: debian-changelog-line-too-long > [usr/share/doc/wifi-qr/changelog.Debian.gz:6] > Fixed. > > I: wifi-qr source: patch-not-forwarded-upstream > [debian/patches/webcam-support] > Fixed. > > Here is an updated changelog on Upload #3 > > * Added patch keyboard-support to fix upstream issues: > - Improved keyboard navigation support (Bug #27). > - Legacy encoding support. > - Removes deprecated Zenity code. > - Applied ShellCheck recommendations for improved script quality. > * Added patch webcam-support to add new features: > - QR scanning functionality with webcam support (Bug #25). > * Added patch appstream-metadata for better software center integration. > * Updated copyright year from 2023 to 2024. > * Extended ignore patterns in source options file. > > > On Sat, Nov 16, 2024 at 9:52 PM Tobias Frost <t...@debian.org> wrote: > > > For completness: > > > > Lintian issues to be fixed: > > > > W: wifi-qr: debian-changelog-line-too-long > > [usr/share/doc/wifi-qr/changelog.Debian.gz:6] > > I: wifi-qr: capitalization-error-in-description WiFi Wi-Fi > > I: wifi-qr: capitalization-error-in-description-synopsis WiFi Wi-Fi > > I: wifi-qr source: patch-not-forwarded-upstream > > [debian/patches/webcam-support] > > (see DEP-3 header how to document patches properly) Lintian still wants Wi-Fi to be spelled correctly. Cheers, -- tobi
