Control: tags -1 +moreinfo -confirmed

Hi, 

- d/changelog is missing entries from old uploads. don't drop them!
- d/changelog is meant for changes to the Debian packaging, not as
  ageneral upstream changelog. Please limit the entries to that what you
  have changed to the package. (Policy ยง4.4)
  Here, as those changes are introduced by a patch, you could reword
  this like;
    
    * Add new patch <name> to fix those upstream issues:
      - <important issue 1>
      - <important issue 2>

  I'd recommend to have one patch per issue (see also below)

- there are changes to the packaging NOT documented in d/changelog,
  e.g the SV-Bump or the update of d/copyright or why you change
  d/source/options.
- ASFAIK the syntax for handling Launchpad bugs (Ubuntu) is LP: #xxxxxxx
  (but I'm not sure, just that I've never seen your syntax.)

It seems that the changes are all stuffed into the single new patch,
this is a bit unfortunate, as it will make handling the patches in
future much more complicated. But as you are upstream, why you don't just
make a new release?


These needs to be fixed/answered before doing an upload.

-- 
tobi




On Thu, Nov 14, 2024 at 08:25:43PM +1100, Ko Ko Ye` wrote:
> Package: sponsorship-requests
> Severity: normal
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "wifi-qr":
> 
>  * Package name     : wifi-qr
>    Version          : 0.3-2
>    Upstream contact : kokoye2007 <kokoye2...@gmail.com>
>  * URL              : https://github.com/kokoye2007/wifi-qr
>  * License          : GPL-3.0+
>  * Vcs              : https://github.com/kokoye2007/wifi-qr
>    Section          : utils
> 
> The source builds the following binary packages:
> 
>   wifi-qr - WiFi password share via QR codes
> 
> ---
>  Usage: wifi-qr [-g] [-c] [-t] [-s] [-z] [-f file] [-p] [-q] [-L] [-v] [-w]
> [-h]
> 
>  -g Launch GUI Main Menu
>  -c Launch WiFi QR Create GUI
>  -t Launch WiFi QR Create Terminal
>  -z Launch WiFi QR Create Terminal Fuzzy Finder
>  -s Launch QR Scan and Auto Connect WiFi
>  -f file Terminal [file] QR Scan and Auto Connect WiFi from file
>  -p Launch GUI [file] QR Scan and Auto Connect WiFi from file
>  -q Launch QR Scan and Connect WiFi GUI
>  -L      Use legacy (backlash) encoding/decoding
>  -v Show WiFi-QR Version 0.3-2
>  -w Launch WiFi QR Wecam Selector
>  -h Show this help message
> ---
> 
> To access further information about this package, please visit the
> following URL:
> 
>   https://mentors.debian.net/package/wifi-qr/
> 
> Alternatively, you can download the package with 'dget' using this command:
> 
>   dget -x
> https://mentors.debian.net/debian/pool/main/w/wifi-qr/wifi-qr_0.3-2.dsc
> 
> Changes since the last upload:
> 
> https://github.com/kokoye2007/wifi-qr/issues/27
> https://github.com/kokoye2007/wifi-qr/issues/25
> 
>  wifi-qr (0.3-2) unstable; urgency=medium
>  .
>    * Applied ShellCheck recommendations for improved script quality.
>    * Improved keyboard navigation support (Bug #27).
>    * Added QR scanning functionality with webcam support (Bug #25).
>    * Update outdated documentation on NetworkManager keyfiles (Closes:
> Ubuntu #2019939).
> 
> Regards,
> YE

Reply via email to