Control: tags -1 +confirmed Kokoye,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Information Running lintian... N: W: wifi-qr: debian-changelog-line-too-long [usr/share/doc/wifi- qr/changelog.Debian.gz:6] N: N: The given line of the latest changelog entry is over 80 columns. Such N: changelog entries may look poor in terminal windows and mail messages and N: be annoying to read. Please wrap changelog entries at 80 columns or less N: where possible. N: N: Visibility: warning N: Show-Always: no N: Check: debian/changelog N: N: I: wifi-qr: capitalization-error-in-description WiFi Wi-Fi N: N: Lintian found a possible capitalization error in the package description. N: Lintian has a list of common capitalization errors, primarily of upstream N: projects, that it looks for. It does not have a dictionary like a spelling N: checker does. N: N: This is a particularly picky check of capitalization in package N: descriptions, since they're very visible to end users, but it will have N: false positives for project names used in a context where they should be N: lowercase, such as package names or executable names. N: N: Visibility: info N: Show-Always: no N: Check: fields/description N: N: I: wifi-qr: capitalization-error-in-description-synopsis WiFi Wi-Fi N: N: Lintian found a possible capitalization error in the package synopsis. N: Lintian has a list of common capitalization errors, primarily of upstream N: projects, that it looks for. It does not have a dictionary like a spelling N: checker does. N: N: Visibility: info N: Show-Always: no N: Check: fields/description N: N: I: wifi-qr source: patch-not-forwarded-upstream [debian/patches/webcam- support] N: N: According to the DEP-3 headers, this patch has not been forwarded N: upstream. N: N: Please forward the patch and try to have it included in upstream's version N: control system. If the patch is not suitable for that, please mention N: not-needed in the Forwarded field of the patch header. N: N: Please refer to social contract item 2, Coordination with upstream N: developers (Section 3.1.4) in the Debian Developer's Reference, Changes to N: the upstream sources (Section 4.3) in the Debian Policy Manual, and N: Bug#755153 for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/patches/dep3 N: Renamed from: send-patch N: I: Lintian run was successful. 3. Licenses [4]: Good 4. Watch file [uscan --force-download]: Warning philwyett@ks-tarkin:~/Development/builder/debian/wifi-qr-0.3$ uscan --force- download uscan warn: Parameter ../0.3 does not have a file extension, guessed a tarball compressed with gzip. Successfully renamed ../0.3 to ../wifi-qr_0.3.orig.tar.gz. 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Good 8. Upgrade [Over previous installs if any]: Good Summary... Package is in good shape, but has a few things noted in the review you may wish to look at for future uploads. If you can I would fix at least the 'debiab/changelog' and 'debian/control' lintian issues before this upload if you can while waiting for DD review. I believe wifi-qr is ready for review/possible sponsorship. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Donations... Buy Me A Coffee: https://buymeacoffee.com/kathenasorg Liberapay: https://liberapay.com/kathenas -- Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
