Julias, One additional question. The upstream source code contains a LICENSE-CC0 file, but debian/copyright does not indicate that any of the file are actually licensed under the CC0. Is that file vestigial or is debian/copyright missing something?
On Monday, October 7, 2024 3:59:44 PM MST Soren Stoutner wrote:
> Julius,
>
> When attempting to build from Salsa using gbp I receive an error (below). I
> think it has something to do with the pristine-tar not liking MUT. However,
I
> was able to use `uscan --download-current-version` and then `sbuild` to
> successfully build the package.
>
> I am not an expert with the interactions between pristine-tar and MUT, but
> there might be someone else on Mentors who can point you in the right
> direction. However, figuring this out isn’t a requirement for me to sponsor
> the package. I am happy to use uscan and sbuild for the release.
>
>
>
> $ gbp buildpackage --git-debian-branch=main
> gbp:info: Creating /home/soren/Downloads/open62541/
open62541_1.4.6.orig.tar.gz
> gbp:info: Performing the build
> dh clean --buildsystem=cmake
> dh_auto_clean -O--buildsystem=cmake
> dh_autoreconf_clean -O--buildsystem=cmake
> dh_clean -O--buildsystem=cmake
> rm -f debian/debhelper-build-stamp
> rm -rf debian/.debhelper/
> rm -f -- debian/libopen62541-1.4.substvars debian/libopen62541-1.4-
> dev.substvars debian/libopen62541-1.4-tools.substvars debian/files
> rm -fr -- debian/libopen62541-1.4/ debian/tmp/ debian/
> libopen62541-1.4-dev/ debian/libopen62541-1.4-tools/
> find . \( \( \
> \( -path .\*/.git -o -path .\*/.svn -o -path .\*/.bzr -o -
path
> .\*/.hg -o -path .\*/CVS -o -path .\*/.pc -o -path .\*/_darcs \) -prune -o -
> type f -a \
> \( -name '#*#' -o -name '.*~' -o -name '*~' -o -name DEADJOE
\
> -o -name '*.orig' -o -name '*.rej' -o -name '*.bak' \ -o -name '.*.orig' -o
> -name .*.rej -o -name '.SUMS' \ -o -name TAGS -o \( -path '*/.deps/*' -a
> -name '*.P' \) \ \) -exec rm -f {} + \) -o \
> \( -type d -a \( -name autom4te.cache -o -name __pycache__
\)
> -prune -exec rm -rf {} + \) \)
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building open62541 using existing ./
> open62541_1.4.6.orig.tar.gz
> dpkg-source: error: cannot represent change to nodeset/ADI/
> Opc.Ua.Adi.PredefinedNodes.uanodes: binary file contents changed
> dpkg-source: error: add nodeset/ADI/Opc.Ua.Adi.PredefinedNodes.uanodes in
> debian/source/include-binaries if you want to store the modified binary in
the
> debian tarball
> dpkg-source: warning: file open62541/nodeset/AnsiC/Opc.Ua.Endpoints.wsdl has
> no final newline (either original or modified version)
> dpkg-source: warning: file open62541/nodeset/AnsiC/Opc.Ua.Services.wsdl has
no
> final newline (either original or modified version)
> dpkg-source: warning: file open62541/nodeset/DotNet/Opc.Ua.Endpoints.wsdl has
> no final newline (either original or modified version)
> dpkg-source: error: cannot represent change to nodeset/DotNet/
> Opc.Ua.PredefinedNodes.uanodes: binary file contents changed
> dpkg-source: error: add nodeset/DotNet/Opc.Ua.PredefinedNodes.uanodes in
> debian/source/include-binaries if you want to store the modified binary in
the
> debian tarball
> dpkg-source: warning: file open62541/nodeset/DotNet/Opc.Ua.Services.wsdl has
> no final newline (either original or modified version)
> dpkg-source: warning: file open62541/nodeset/DotNet/Opc.Ua.StatusCodes.csv
has
> no final newline (either original or modified version)
> dpkg-source: error: cannot represent change to nodeset/FDI/
> Opc.Ua.Fdi5.PredefinedNodes.uanodes: binary file contents changed
> dpkg-source: error: add nodeset/FDI/Opc.Ua.Fdi5.PredefinedNodes.uanodes in
> debian/source/include-binaries if you want to store the modified binary in
the
> debian tarball
> dpkg-source: error: cannot represent change to nodeset/FDI/
> Opc.Ua.Fdi7.PredefinedNodes.uanodes: binary file contents changed
> dpkg-source: error: add nodeset/FDI/Opc.Ua.Fdi7.PredefinedNodes.uanodes in
> debian/source/include-binaries if you want to store the modified binary in
the
> debian tarball
> dpkg-source: error: cannot represent change to nodeset/GDS/
> Opc.Ua.Gds.PredefinedNodes.uanodes: binary file contents changed
> dpkg-source: error: add nodeset/GDS/Opc.Ua.Gds.PredefinedNodes.uanodes in
> debian/source/include-binaries if you want to store the modified binary in
the
> debian tarball
> dpkg-source: warning: file open62541/nodeset/IOLink/
Opc.Ua.IOLink.NodeSet2.xml
> has no final newline (either original or modified version)
> dpkg-source: warning: file open62541/nodeset/IOLink/
> Opc.Ua.IOLinkIODD.NodeSet2.xml has no final newline (either original or
> modified version)
> dpkg-source: error: cannot represent change to nodeset/MDIS/
> Opc.MDIS.PredefinedNodes.uanodes: binary file contents changed
> dpkg-source: error: add nodeset/MDIS/Opc.MDIS.PredefinedNodes.uanodes in
> debian/source/include-binaries if you want to store the modified binary in
the
> debian tarball
> dpkg-source: error: cannot represent change to nodeset/MTConnect/
> Opc.Ua.MTConnect.PredefinedNodes.uanodes: binary file contents changed
> dpkg-source: error: add nodeset/MTConnect/
> Opc.Ua.MTConnect.PredefinedNodes.uanodes in debian/source/include-binaries if
> you want to store the modified binary in the debian tarball
> dpkg-source: warning: file open62541/nodeset/PADIM/Opc.Ua.IRDI.NodeSet2.xml
> has no final newline (either original or modified version)
> dpkg-source: warning: file open62541/nodeset/Robotics/
> Opc.Ua.Robotics.Classes.cs has no final newline (either original or modified
> version)
> dpkg-source: warning: file open62541/nodeset/Robotics/
> Opc.Ua.Robotics.Constants.cs has no final newline (either original or modified
> version)
> dpkg-source: warning: file open62541/nodeset/Robotics/
> Opc.Ua.Robotics.DataTypes.cs has no final newline (either original or modified
> version)
> dpkg-source: warning: file
> open62541/nodeset/Robotics/Opc.Ua.Robotics.Types.bsd has no final newline
> (either original or modified version)
> dpkg-source: warning: file
> open62541/nodeset/Robotics/Opc.Ua.Robotics.Types.xsd has no final newline
> (either original or modified version)
> dpkg-source: warning: file open62541/nodeset/Robotics/OpcUaRoboticsModel.xml
> has no final newline (either original or modified version)
> dpkg-source: warning: file open62541/nodeset/Safety/Opc.Ua.Safety.Types.xsd
> has no final newline (either original or modified version)
> dpkg-source: warning: file open62541/nodeset/Schema/Opc.Ua.Endpoints.wsdl has
> no final newline (either original or modified version)
> dpkg-source: warning: file open62541/nodeset/Schema/Opc.Ua.Services.wsdl has
> no final newline (either original or modified version)
> dpkg-source: warning: file open62541/nodeset/Schema/StatusCode.csv has no
> final newline (either original or modified version)
> dpkg-source: error: cannot represent change to nodeset/Sercos/
> Sercos.PredefinedNodes.uanodes: binary file contents changed
> dpkg-source: error: add nodeset/Sercos/Sercos.PredefinedNodes.uanodes in
> debian/source/include-binaries if you want to store the modified binary in
the
> debian tarball
> dpkg-source: error: cannot represent change to nodeset/UAFX/
> opc.ua.fx.ac.nodeset2.ua: binary file contents changed
> dpkg-source: error: add nodeset/UAFX/opc.ua.fx.ac.nodeset2.ua in debian/
> source/include-binaries if you want to store the modified binary in the
debian
> tarball
> dpkg-source: error: cannot represent change to nodeset/UAFX/
> opc.ua.fx.cm.nodeset2.ua: binary file contents changed
> dpkg-source: error: add nodeset/UAFX/opc.ua.fx.cm.nodeset2.ua in debian/
> source/include-binaries if you want to store the modified binary in the
debian
> tarball
> dpkg-source: error: cannot represent change to nodeset/UAFX/
> opc.ua.fx.data.nodeset2.ua: binary file contents changed
> dpkg-source: error: add nodeset/UAFX/opc.ua.fx.data.nodeset2.ua in debian/
> source/include-binaries if you want to store the modified binary in the
debian
> tarball
> dpkg-source: error: cannot represent change to nodeset/Woodworking/
> Opc.Ua.Eumabois.Nodeset2.ua: binary file contents changed
> dpkg-source: error: add nodeset/Woodworking/Opc.Ua.Eumabois.Nodeset2.ua in
> debian/source/include-binaries if you want to store the modified binary in
the
> debian tarball
> dpkg-source: error: unrepresentable changes to source
> E: Failed to package source directory /home/soren/Downloads/open62541/
> open62541
> gbp:error: 'sbuild' failed: it exited with 1
>
>
>
>
> Lintian lists the following information. The first item stands out to me.
> Symbols files are a large topic (and one in which I am not an expert). I
> would recommend you read over the documentation in the lintian information.
> If you intentionally decide not to ship a symbols file, you can override the
> lintian tag with a comment as to why (there is some debate as to if you
> should do so with C++ projects, but I do not believe that applies to
> libraries written in C, and I know that the KDE/Qt team includes them with
> C++ anyway and has developed some rather sophisticated scripts that
> facilitate it).
>
> https://qt-kde-team.pages.debian.net/symbolfiles.html
>
> You should consider each of the other lintian tags and either fix them or
> override them if they are false positives. For the spelling errors in the
> binary, you can fix them upstream for a future release, but we don’t need to
> wait for that to land for me to sponsor the Debian package.
>
> I: libopen62541-1.4: no-symbols-control-file usr/lib/x86_64-linux-gnu/
> libopen62541.so.1.4.6
> N:
> N: Although the package includes a shared library, the package does not
have
> N: a symbols control file.
> N:
> N: dpkg can use symbols files in order to generate more accurate library
> N: dependencies for applications, based on the symbols from the library
that
> N: are actually used by the application.
> N:
> N: Please refer to the dpkg-gensymbols(1) manual page and
> N: https://wiki.debian.org/UsingSymbolsFiles for details.
> N:
> N: Visibility: info
> N: Show-Always: no
> N: Check: debian/shlibs
> N:
> N:
> I: libopen62541-1.4-tools: package-contains-documentation-outside-usr-share-
> doc [usr/share/open62541/nodeset_compiler/NodeID_NS0_Base.txt]
> N:
> N: This package ships a documentation file outside /usr/share/doc
> N: Documentation files are normally installed inside /usr/share/doc.
> N:
> N: If this file doesn't describe the contents or purpose of the directory
it
> N: is in, please consider moving this file to /usr/share/doc/ or maybe even
> N: removing it. If this file does describe the contents or purpose of the
> N: directory it is in, please add a lintian override.
> N:
> N: Visibility: info
> N: Show-Always: no
> N: Check: documentation
> N:
> N: Screen: python/egg/metadata
> N: Advocates: "Scott Kitterman" <deb...@kitterman.com>
> N: Reason: The folders XXX.dist-info/ and XXX.egg-info/ hold metadata
for
> N: Python modules. Those files are not documentation even though
> N: some of their names carry the .txt file extension.
> N:
> N: Python modules can be both public and private.
> N:
> N: Read more in
> N:
> https://www.python.org/dev/peps/pep-0427/#the-dist-info-directory, N:
> https://www.python.org/dev/peps/pep-0376/#id16,
> N: https://www.python.org/dev/peps/pep-0610/,
> N: https://www.python.org/dev/peps/pep-0639/,
> N: https://setuptools.pypa.io/en/latest/deprecated/
> python_eggs.html,
> N: and Bug#1003913.
> N:
> N:
> I: libopen62541-1.4-tools: package-contains-documentation-outside-usr-share-
> doc [usr/share/open62541/nodeset_compiler/README.md]
> N:
> I: libopen62541-1.4: spelling-error-in-binary explicity explicitly [usr/lib/
> x86_64-linux-gnu/libopen62541.so.1.4.6]
> N:
> N: Lintian found a spelling error in the given binary. Lintian has a list
of
> N: common misspellings that it looks for. It does not have a dictionary
> like N: a spelling checker does.
> N:
> N: If the string containing the spelling error is translated with the help
> of
> N: gettext or a similar tool, please fix the error in the translations as
> N: well as the English text to avoid making the translations fuzzy. With
> N: gettext, for example, this means you should also fix the spelling
mistake
> N: in the corresponding msgids in the *.po files.
> N:
> N: You can often find the word in the source code by running:
> N:
> N: grep -rw <word> <source-tree>
> N:
> N: This tag may produce false positives for words that contain non-ASCII
> N: characters due to limitations in strings.
> N:
> N: Visibility: info
> N: Show-Always: no
> N: Check: binaries/spelling
> N:
> N:
> I: libopen62541-1.4: spelling-error-in-binary wtH with [usr/lib/x86_64-
linux-
> gnu/libopen62541.so.1.4.6]
>
>
>
> Your debian/copyright needs a section for debian/*. See, for example,
> privacybrowser:
>
> https://salsa.debian.org/soren/privacybrowser/-/blob/master/debian/
copyright?
> ref_type=heads
>
>
> Your debian/changelog contains the following line:
>
> * Initial package based on open62541 v1.4.6 (closes: #985909)
>
> Customarily, this would be shorted to the following, as the release header
> already specifies it is open62541 release 1.4.6.
>
> * Initial release (closes: #985909).
>
> On Sunday, October 6, 2024 12:02:31 PM MST Julius Pfrommer wrote:
> > Soren,
> >
> > Earlier today we released open62541 v1.4.6.
> > We put the Debian package on hold until this release due to a security
>
> related
>
> > issue under an embargo period for the public release.
> >
> > The package is now updated to v1.4.6 and uses the multiple upstream
tarball
> > (MUT) pattern. Mentors shows no more issues (#16) and the package is up to
> > date on Salsa (https://salsa.debian.org/jpfr/open62541).
> >
> > From our current understanding the package is good to go.
> > Thanks for the guidance and continuing support.
> >
> > --
> > Regards, Julius
--
Soren Stoutner
so...@debian.org
signature.asc
Description: This is a digitally signed message part.
