Hi Phil, I imported the project to Salsa, but I found some examples online of people using github as the vcs, curious to if it's preferred or necessary to use Salsa at present?
E.g. https://github.com/Debian/dcs/blob/main/debian/control Vcs-Browser: https://github.com/Debian/dcs/ Vcs-Git: https://github.com/Debian/dcs/ If it's workable that way, seems easier but if not, should I put the entries in debian/control like this: Vcs-Git: https://salsa.debian.org/adanisch/bashbro.git Vcs-Browser: https://salsa.debian.org/adanisch/bashbro Thanks, +Ad On Wed, Aug 7, 2024 at 10:51 PM Phil Wyett <philip.wy...@kathenas.org> wrote: > Adam, > > Preamble... > > Thank you for taking the time to prepare this package and your contribution > to the Debian project. > > The review below is for assistance. This review is offered to help package > submitters to Debian mentors inorder to improve their packages prior to > possible sponsorship into Debian. There is no obligation on behalf of the > submitter to make any alterations based upon information provided in the > review. > > Review... > > 1. Build: > > * pbuilder [1]: Good > * sbuild [2]: Good > > 2. Lintian [3]: Good > > 3. Licenses [4]: Good > > 4. Watch file [uscan --force-download]: Good > > 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good > > 6. Reproducible builds [5]: Good > > 7. Install [No previous installs]: Good > > 8. Upgrade [Over previous installs if any]: N/A > > Summary... > > bashbro is looking look, great work. The one last thing that needs to be > addressed are the Vcs fields for 'debian/control'. The easiest thing to do > here would to create an empty bashbro git repository under your own > account/namespace on Salsa and import your package in, then add thos Vcs > fields for now. The package can be moved into the 'debian' group if/when > the > package is accepted into Debian. > > Regards > > Phil > > [1] pbuilder: > > * Command: sudo pbuilder build <PACKAGE>.dsc > * Document: https://wiki.ubuntu.com/PbuilderHowto. > * Document: https://wiki.debian.org/PbuilderTricks > > [2] sbuild: > > * Command: sbuild <PACKAGE>.dsc > * Document: https://wiki.debian.org/sbuild > > [3] lintian: > > * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, > *.changes, *.buildinfo). Each can throw up different results, so be > thorough. > * Document: https://wiki.debian.org/Lintian > > [4] lrc: > > * Command: lrc -t > * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon > > [5] reprotest > > * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 > --auto- > build <PACKAGE>dsc -- schroot unstable-amd64-sbuild > * Document: https://wiki.debian.org/ReproducibleBuilds/ > * Document: > https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method > > -- > > "I play the game for the game’s own sake" > > Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans > > -- > > Buy Me A Coffee: https://buymeacoffee.com/kathenasorg > > Internet Relay Chat (IRC): kathenas > > Matrix: #kathenas:matrix.org > > Website: https://kathenas.org > > Instagram: https://instagram.com/kathenasorg/ > > Threads: https://www.threads.net/@kathenasorg > > -- > > > > > > > -- Adam Michael Danischewski Software Engineer Phone: (929) 308-9674 Email: adam.danischew...@gmail.com Github: http://github.com/AdamDanischewski
