Control: tags -1 + moreinfo

Adam,

Preamble...

Thank you for taking the time to create this package and your contribution
to the Debian project.

The review below is for assistance. This review is offered to help
package submitters to Debian mentors inorder to improve their packages
prior to possible sponsorship into Debian. There is no obligation on behalf
of the submitter to make any alterations based upon information provided
in the review.

Review...

1. Build[1]: Good

2. Lintian[2]: Issue

W: bashbro source: file-without-copyright-information README.md
[debian/copyright]
N: 
N:   The source tree contains a file which was not matched by any of the
Files
N:   paragraphs in debian/copyright. Either adjust existing wildcards to
match
N:   that file or add a new Files paragraph.
N: 
N:   Please refer to
N:   https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for
N:   details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: debian/copyright/dep5
N: 
N:
W: bashbro source: file-without-copyright-information bashbro
[debian/copyright]
N:
W: bashbro source: file-without-copyright-information bashbro.1
[debian/copyright]
N:
W: bashbro source: file-without-copyright-information debian/changelog
[debian/copyright]
N:
W: bashbro source: file-without-copyright-information debian/control
[debian/copyright]
N:
W: bashbro source: file-without-copyright-information debian/copyright
[debian/copyright]
N:
W: bashbro source: file-without-copyright-information debian/install
[debian/copyright]
N:
W: bashbro source: file-without-copyright-information debian/manpages
[debian/copyright]
N:
W: bashbro source: file-without-copyright-information debian/options
[debian/copyright]
N:
W: bashbro source: file-without-copyright-information debian/rules
[debian/copyright]
N:
W: bashbro source: file-without-copyright-information debian/source/format
[debian/copyright]
N:
W: bashbro source: file-without-copyright-information debian/source/options
[debian/copyright]
N:
W: bashbro source: file-without-copyright-information
debian/upstream/metadata [debian/copyright]
N:
W: bashbro source: file-without-copyright-information debian/watch
[debian/copyright]
N:
W: bashbro source: newer-standards-version 4.7.0 (current is 4.6.2)
N: 
N:   The source package refers to a Standards-Version which is newer than the
N:   highest one Lintian is programmed to check.
N:   
N:   If the source package is correct, please upgrade Lintian to the newest
N:   version.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: fields/standards-version

See: Section 3.

I: bashbro: synopsis-is-a-sentence "Bash-based web file browser."
N: 
N:   The package synopsis (also known as the "short" description, ie. the
first
N:   line in the package's "Description:" field) either ends with a full stop
N:   "." character or starts another sentence.
N:   
N:   This is not necessary as the synopsis does not need to be a full
sentence.
N:   It is recommended that a single descriptive phrase is used instead.
N:   
N:   Note also that the synopsis is not part of the rest of the "long"
N:   Description: field.
N: 
N:   Please refer to The package synopsis, or short description (Section
6.2.2)
N:   in the Debian Developer's Reference for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: fields/description
N:   Renamed from: description-synopsis-might-not-be-phrased-properly

3. Licenses (lrc[3]): Issue

You need to make your 'debian/copyright' look like below.

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://github.com/victrixsoft/bashbro.git 
Upstream-Name: bashbro
Upstream-Contact: Adam Danischewski <adam.danischew...@gmail.com> 

Files: *
Copyright: 2024 Adam Danischewski <adam.danischew...@gmail.com>
License: GPL-3+

Files: debian/*
Copyright: 2024 Adam Danischewski <adam.danischew...@gmail.com>
License: GPL-3+
 This package is free software; you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by
 the Free Software Foundation; either version 3 of the License, or
 (at your option) any later version.
 .
 This package is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 GNU General Public License for more details.
 .
 You should have received a copy of the GNU General Public License
 along with this program. If not, see <https://www.gnu.org/licenses/>
Comment: On Debian systems, the complete text of the GNU General
 Public License version 3 can be found in "/usr/share/common-licenses/GPL-3".

4. Watch file (uscan --force-download): Good

5. Build Twice (sudo pbuilder build --twice <package>.dsc): Good

6. Reproducible builds (reporotest)[3]: Good

7. Install (No previous installs): Good

8. Upgrade (Over previous installs if any): N/A

Summary...

I believe bashbro is not yet ready for sponsorship/upload. Could the
contributor rectify one of more of the rasied issues. Once updated to your
satisfaction and a new upload done, please remove the 'moreinfo' on the
Request For Sponsorship (RFS) bug report.

Regards

Phil

[1] Using:
      * pbuilder - https://wiki.ubuntu.com/PbuilderHowto.
      * https://wiki.debian.org/PbuilderTricks
    and
      * sbuild - https://wiki.debian.org/sbuild.

[2] Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
    *.changes, *.buildinfo). Each can throw up different, so be thorough.

[3] 'lrc' from 'licenserecon' is located in Debian testing and newer.

[4] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

-- 
"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Internet Relay Chat (IRC): kathenas

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg/

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

--

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to