Control: tags -1 + moreinfo

Adam,

Preamble...

Thank you for taking the time to create this package and your contribution
to the Debian project.

The review below is for assistance. This review is offered to help
package submitters to Debian mentors inorder to improve their packages
prior to possible sponsorship into Debian. There is no obligation on behalf
of the submitter to make any alterations based upon information provided
in the review.

Review...

1. Build[1]: Issue

* pbuilder - Good.

* sbuild - Issue.

+----------------------------------------------------------------------------
--+
| Build                                                                     
|
+----------------------------------------------------------------------------
--+


Unpack source
-------------

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 3.0 (quilt)
Source: bashbro
Binary: bashbro
Architecture: all
Version: 1.06-1
Maintainer: Adam Danischewski <adam.danischew...@gmail.com>
Homepage: https://github.com/victrixsoft/bashbro
Standards-Version: 4.6.2
Build-Depends: debhelper-compat (= 13)
Package-List:
 bashbro deb net optional arch=all
Checksums-Sha1:
 9af07653bc941d5801722c4f6a69d31d42d9e0da 55055 bashbro_1.06.orig.tar.gz
 c8c5d6b83d6b6ddcd7bdf12ba871cd33b8693732 833 bashbro_1.06.orig.tar.gz.asc
 4466d55ca73d9298e9d84e98152df2b8e303182b 1624 bashbro_1.06-1.debian.tar.xz
Checksums-Sha256:
 eb72fae43ecd6f33786a7b48d0b29a85f31e50ea178218e01f395e0cfb79f6d1 55055
bashbro_1.06.orig.tar.gz
 b47c98f3b7529c24f954df10c51df72208cfbc87886e614cf6f9d72712802745 833
bashbro_1.06.orig.tar.gz.asc
 1aa223eb606d7b9ea54619c15605213c1c45505bc870a318fe82cf7159bbcb8c 1624
bashbro_1.06-1.debian.tar.xz
Files:
 fc63622191eada63c4ebbc3897f8e11e 55055 bashbro_1.06.orig.tar.gz
 b8c9818123c1fc791c80a67183b16e0d 833 bashbro_1.06.orig.tar.gz.asc
 426dab5b6bfdca1d900d8b8410f01220 1624 bashbro_1.06-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJQBAEBCgA6FiEExd6kuGW5c877nSh7L1txbzUHkXQFAmacoD4cHGFkYW0uZGFu
aXNjaGV3c2tpQGdtYWlsLmNvbQAKCRAvW3FvNQeRdN61D/9h5xx4Lc3B22g6sCGb
olQAtxiJJmDy7+cMnq4mF0liYIuCKvNjXTQfNG0aml2IQiQoDc5+2C9YE3rdh1eU
N4sm7dGYLeKG5er+HyV+ru18Vq5Uw/6VUCorMNN7xENdKvgHt6H5msiCD1IggCSr
IMiOkFMi6XWi6STM3xQjY7L9RMlQw6seWmF3G8UWKsWXgN3sDP+fG8JCwFrsP8EL
8pV5P+U0SoDQ+nRjera4+fXsKGsf3D42MSDQKSVEmvcHBSTS2hoVEmEr34QU/uoq
j0sJtDE0aFxy5RL6B8uHG3jvIpHSgp9MWyIR5JFzZ0rrBbfL1hJKnIKqUSjoCo1U
h+KX0zl6Mj4mUXAUlkdU0qwsywiUzlhpgFEegdNPfUvbdFmyw3IspbjorHKwK4F8
8n5f3pneQHDLqH5aOlZScqCdZ6TwCcRwCxAzQafsQCf1DyvCbXnAcE2XpI6cfXl6
GZHYQx0rJBDRVO9/voxa96kbqjUYa/jHHsieyupbWK+YbzZkFgfMe34A03mm076l
vqTjw5xiDxAmuTpUxGk6ttyzzpWjGwziNPeS21egm7CgTzOADAS6lns12+1Mdag2
SAVkrfD/7KTDfJ8+t3DBCtOVqz9AQfk78kGy1jRi0ffNwoMMkAKkgJtS6lIY9fVZ
nZ4qL2SMGMGkYH76JiqDyHU7Dw==
=BiV6
-----END PGP SIGNATURE-----

gpgv: Signature made Sun Jul 21 05:44:30 2024 UTC
gpgv:                using RSA key C5DEA4B865B973CEFB9D287B2F5B716F35079174
gpgv:                issuer "adam.danischew...@gmail.com"
gpgv: Can't check signature: No public key
dpkg-source: warning: cannot verify inline signature for ./bashbro_1.06-
1.dsc: no acceptable signature found
dpkg-source: error: file ./bashbro_1.06.orig.tar.gz has size 18580 instead of
expected 55055
E: FAILED [dpkg-source died]

2. Lintian[2]: Not performed at this time

3. Licenses (lrc[3]): Issue

The 'Files: *' section is missing.

philwyett@ks-solo:~/Development/builder/debian/mentoring/bashbro-1.06$ lrc
: Versions: recon 1.12  check 3.3.9-1

Parsing Source Tree  ....
Reading copyright    ....
Running licensecheck ....

d/copyright     | licensecheck

                | GPL-3+           bashbro

4. Watch file (uscan --force-download): Good

5. Build Twice (sudo pbuilder build --twice <package>.dsc): Good

6. Reproducible builds (reporotest)[3]: Not performed at this time

7. Install (No previous installs): Not performed at this time

8. Upgrade (Over previous installs if any): Not performed at this time

Additional...

A. Please update 'Standards-Version' in 'debian/control' to latest 4.7.0 as
per Debian policy[5].

B. Remove '.git' directory from release archive file(s) or other solution.

Summary...

I believe bashbro is not yet ready for sponsorship/upload. Could the
contributor rectify one of more of the rasied issues. Once updated to your
satisfaction and a new upload done, please remove the 'moreinfo' on the
Request For Sponsorship (RFS) bug report.

Regards

Phil

[1] Using:
      * pbuilder - https://wiki.ubuntu.com/PbuilderHowto.
      * https://wiki.debian.org/PbuilderTricks
    and
      * sbuild - https://wiki.debian.org/sbuild.

[2] Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
    *.changes, *.buildinfo). Each can throw up different, so be thorough.

[3] 'lrc' from 'licenserecon' is located in Debian testing and newer.

[4] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

[5] https://www.debian.org/doc/debian-policy/

-- 
"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Internet Relay Chat (IRC): kathenas

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg/

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

--

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to