Manuel, Preamble...
Thank you for taking time to create this package and your contribution to Debian. The below review is for assistance. It is offered to help submitters of packages to Debian mentors improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: Good Note: Autopkgtest: pass 2. Lintian: Issues E: baby: unstripped-binary-or-object [usr/bin/baby] N: N: The package installs an unstripped binary or object file. N: N: Please note, that shared libraries have to be stripped with the N: --strip-unneeded option. N: N: Please refer to Binaries (Section 10.1) in the Debian Policy Manual and N: Libraries (Section 10.2) in the Debian Policy Manual for details. N: N: Visibility: error N: Show-Always: no N: Check: binaries/debug-symbols W: baby: shared-library-lacks-prerequisites [usr/bin/baby] N: N: The listed shared library doesn't include information about the other N: libraries against which it was linked. N: N: More specifically, "ldd foo.so" should report such other libraries. In N: your case, it reports "statically linked". N: N: The fix is to specify the libraries. One way to do so is to add something N: like "-lc" to the command-line options for "ld". N: N: Visibility: warning N: Show-Always: no N: Check: binaries/prerequisites N: Renamed from: shared-lib-without-dependency-information N: N: Screen: coq/cmxs/prerequisites N: Advocates: "Julien Puydt" <julien.pu...@gmail.com> N: Reason: The Coq project comes with a kind of compiler that generates N: files which are ELF shared objects. Unfortunately, they contain N: many undefined symbols, but those are expected. N: N: There are a lot of false positives. N: N: Read more in Bug#999602. I: baby: file-references-package-build-path [usr/bin/baby] N: N: The listed file or maintainer script appears to reference the build path N: used to build the package as specified in the Build-Path field of the N: .buildinfo file. N: N: This is likely to cause the package to be unreproducible, but it may also N: indicate that the package will not work correctly outside of the N: maintainer's own system. N: N: Please note that this tag will not appear unless the .buildinfo file N: contains a Build-Path field. That field is optional. You may have to set N: DEB_BUILD_OPTIONS=buildinfo=+path or use N: --buildinfo-option=--always-include-path with dpkg-buildpackage when N: building. N: N: Please refer to https://reproducible-builds.org/, N: https://wiki.debian.org/ReproducibleBuilds/BuildinfoFiles, and the N: dpkg-genbuildinfo(1) manual page for details. N: N: Visibility: info N: Show-Always: no N: Check: files/contents I: baby source: override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS [debian/rules:50] N: N: The debian/rules file for this package has an override_dh_auto_test target N: that does not appear to check DEB_BUILD_OPTIONS against nocheck. N: N: As this check is not automatically performed by debhelper(1), the N: specified testsuite is run regardless of another maintainer using the N: nocheck build option. N: N: Please add a check such as: N: N: override_dh_auto_test: N: ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) N: ./run-upstream-testsuite N: endif N: N: Lintian will ignore comments and other lines such as: N: N: # Disabled N: : Disabled N: echo "Disabled" N: mkdir foo/ N: ENV=var dh_auto_test -- ARG=value N: N: This check is not required in Debhelper compat level 13 or greater (see N: Bug#568897). N: N: Please refer to debian/rules and DEB_BUILD_OPTIONS (Section 4.9.1) in the N: Debian Policy Manual and N: https://wiki.debian.org/BuildProfileSpec#Registered_profile_names for N: details. N: N: Visibility: info N: Show-Always: no N: Check: debian/rules 3. Licenses (lrc): Good 4. Watch file (uscan --force-download): Issues philwyett@ks-windu:~/Development/builder/debian/mentoring/baby-1.0.39$ uscan -- force-download uscan warn: unknown protocol for LWP: pgpsigurlmangle=s/.+\/v?(\d\S+)\.tar\.gz.asc/#debian/upstream/signing-key.asc Successfully renamed ../v1.0.38.tar.gz to ../baby_1.0.38.orig.tar.gz. Also make sure the watch file is retrieving the same version that you have submitted to mentors. 5. Build Twice (sudo pbuilder build --twice <package>.dsc): Good 6. Reproducible builds (reporotest)[1]: Good 7. Install (No previous installs): Good 8. Upgrade (Over previous installs if any): N/A Additional... A. 'debian/control' - Update 'Standards-Version' to latest 4.7.0 as per Debian policy[2]. B. 'debian/changelog' - A new package to Debian, should have only one changelog entry. Example below. <PACKAGE_NAME> (<PACKAGE_VERSION>-<DEBIAN_REVISION>) unstable; urgency=medium * Initial release (Closes: #<ITP_BUG_NUMBER>) Summary... I believe 'baby' is not yet ready for sponsorship/upload. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' on the Request For Sponsorship (RFS) bug report. [1] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method Regards Phil -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg --
signature.asc
Description: This is a digitally signed message part
