On Fri, 2024-07-05 at 02:24 -0400, James Montgomery wrote: > > Control: tags -1 - moreinfo > > Hi Phil, > > Thank you for taking the time to review my package and for your invaluable > feedback.I've gone through and updated the copyright, switched to sbuild, and > incorporated reprotest. I've included a snippet of the output > > sbuild -d unstable mangl_1.1.5-1.dsc > +------------------------------------------------------------------------------+ > | Summary > | > +------------------------------------------------------------------------------+ > > Build Architecture: amd64 > Build Type: binary > Build-Space: 15948 > Build-Time: 6 > Distribution: unstable > Host Architecture: amd64 > Install-Time: 17 > Job: /home/montj2/git/mangl_1.1.5-1.dsc > Lintian: pass > Machine Architecture: amd64 > Package: mangl > Package-Time: 28 > Source-Version: 1.1.5-1 > Space: 15948 > Status: successful > Version: 1.1.5-1 > -------------------------------------------------------------------------------- > Finished at 2024-07-05T05:27:04Z > Build needed 00:00:28, 15948k disk space > > > reprotest --vary=-build_path,domain_host.use_sudo=1 mangl_1.1.5-1.dsc > ======================= > Reproduction successful > ======================= > No differences in ./*.*deb > 85919d375a6d4425ecfb0dbda9c78cdc8485ee5a3f6bf8bf22de689bb6274725 > ./mangl-dbgsym_1.1.5-1_amd64.deb > 5cef64a4b5cbbf971298618747fe389ea6f2fbdcc0a17fb09505e60c7df2324b > ./mangl_1.1.5-1_amd64.deb > > > Please let me know if there are any additional changes or improvements > required.Additionally, if you're willing and able to share your review > process as it would be helpful as a readiness check my next time around :) > > Kind regards, > > James > >
Good morning James, Firstly, many thanks for the donation through buy me a coffee. Your donation will go into the pot for my new daily driver dev laptop which I am weighing the options for the replacement to my custom built PC Specialist[2] machine that is now 5 years old, still good and has given loyal service. :-) Preamble... Thanks for taking time to create this package and your contribution to Debian. The below review is for assistance. It is offered to help submitters of packages to Debian mentors improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the subitter to make any alterations based upon information provided in the review. Review... 1. Build: Good 2. Lintian: Issue I: mangl source: unused-license-paragraph-in-dep5-copyright bsd-3-clause [debian/copyright:83] N: N: The license paragraph in the machine-readable copyright file is not N: referenced by any files paragraph. It could be a typo in the license name N: or the license paragraph is simply not needed and can be removed. N: N: Please refer to N: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for N: details. N: N: Visibility: info N: Show-Always: no N: Check: debian/copyright/dep5 Can be removed. I: mangl: desktop-entry-contains-encoding-key Encoding [usr/share/applications/mangl.desktop:2] N: N: The Encoding key is deprecated in the FreeDesktop standard. Instead, all N: strings must now be encoded in UTF-8. This desktop entry specifies an N: Encoding of UTF-8. It is harmless but can be dropped. N: N: The desktop-file-validate tool in the desktop-file-utils package may be N: useful for checking the syntax of desktop entries. N: N: Please refer to N: https://specifications.freedesktop.org/desktop-entry-spec/latest/apc.html N: for details. N: N: Visibility: info N: Show-Always: no N: Check: menu-format Keywords is an upstream thing and you can suggest adding them. The benefits for certain types of software such as software centres etc. is known. Do not be downhearted if they will not add them, just one of those things. 3. Licenses: Issue philwyett@ks-windu:~/Development/builder/debian/mentoring/mangl-1.1.5$ lrc en: Versions: recon 1.11 check 3.3.9-1 Parsing Source Tree .... Reading copyright .... Running licensecheck .... d/copyright | licensecheck ISC | BSD-3-clause mandoc/compat_err.c ISC | BSD-3-clause mandoc/compat_fts.c ISC | BSD-3-clause mandoc/compat_fts.h ISC | BSD-3-clause mandoc/compat_getsubopt.c ISC | BSD-3-clause mandoc/compat_strcasestr.c BSD-2-Clause-NetBSD| BSD-2-Clause-NetBSD and/or BSD-2-clause mandoc/compat_stringlist.c BSD-2-Clause-NetBSD| BSD-2-Clause-NetBSD and/or BSD-2-clause mandoc/compat_stringlist.h ISC | BSD-3-clause mandoc/compat_strsep.c ISC | BSD-3-clause mandoc/man.1 Unlicense | Expat and/or Unlicense stretchy_buffer.h The one I am curious about is the ISC. Looking at the files and other packages that have this "The Regents of the University of California. All rights reserved." these tend to fall under a BSD license. I would be happy for Andrey or another DD to offer advice here, as they know more than I. 4. Build Twice (sudo pbuilder build --twice <package>.dsc): Good 5. Reproducible builds (reporotest)[1]: Good 6. Install (No previous installs): Good 7. Upgrade (Over previous installs if any): N/A [1] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method [2] https://www.pcspecialist.co.uk/ Do not support GNU Linux, but you can get a machine as I did with no OS, so no Windows tax. Regards Phil -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
signature.asc
Description: This is a digitally signed message part
