[2019-07-19 12:57] Paride Legovini <p...@ninthfloor.org>
> Package: sponsorship-requests
> Severity: normal
>
> Please review my packaging branch for irqbalance/1.6.0-1 at:
>
> https://salsa.debian.org/paride-guest/irqbalance
> [...]
On your changes:
1. In [942ed5e] you added this line:
export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
Why is it needed? Maybe, these flags should be provided by
dpkg-buildflags(1)?
2. I think manpage in wrong direction should be patched, not overrided.
On package in general (does not block upload). These issues were present
before your changes, but it would be nice to solve them.
3. What is "irqbalance-ui"? It has no manpage, not referenced in
irqbalance(1) and even after source diving I can't understand how to
use it.
4. Situation with "oneshot" option is quite... inconvenient.
* If you have ONESHOT option set, `/etc/init.d/irqbalance status`
will report failure. It can be fixed by checking for ONESHOT
variable in status) clause;
* current runscript does not respect ONESHOT option. It can be fixed
with something like
#!/bin/sh
. /etc/default/irqbalance
if [ -n "${ONESHOT:-}" ] ; then
irqbalance --oneshot
sv down irqbalance
else
exec irqbalance --foreground
fi
but it would be quite unnatural. I think proper solution would be
separation of /etc/init.d/irqbalance and /etc/init.d/irqbalance-oneshot.
5. Do we really need debconf to configure oneshot feature? Debconf
question block installation process, so they are not to be used
lightly, imho. Even ssh server does not use debconf to make me
review its config, which is of much more importance.
--
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.
